Tobias Bieniek

Results 665 comments of Tobias Bieniek

@arcanis that only works if `yarn run` is used though, right? > * When `useYarn: true` we should detect `./.pnp.js` and add `--pnp` option I'm not sure if this is...

this looks like a breaking change to me. for someone on an older version of the addon blueprint it would recursively run `ember-try` then 🤔

> * wait for settled before tearing them down seems like a good option to me 🤔

that suggestion seems reasonable to me 👍

hmm, I don't think we should blur at the end. what we could potentially do is blur at the start if the focus is on another element. or am I...

```js if (document.activeElement !== targetElement) { await blur(document.activeElement); } ``` something like that, yeah

it was not intended functionality when we developed this addon, but I'm happy to merge PRs that fix it 😉

@danwenzel that's unrelated though. the qunit-console-grouper generally does not work properly with ember-qunit 5 yet. I have a work-in-progress branch though, so hopefully it won't be that much longer until...

I would prefer them to be open by default to be closer to the behavior that we see when not using this plugin. But maybe we can find a way...

@stefanpenner @rwjblue @nathanhammond @krisselden any comments on this?