Tobias Bieniek comments

Results 665 comments of


                                            Tobias Bieniek

Encode '+' sign in static.crates.io URLs

Step 4 for of the above issue has been implemented by https://github.com/rust-lang/simpleinfra/pull/313, which means that `+` will keep being supported for now. I guess we can close this issue? or...

Support translations in addons (and in-repo-addons)

it looks like this has not been implemented yet. #481 only added support for looking up translations within an addon for apps, but not for running the analyzer on addons...

Check Intl config for inputPath

out of curiosity, why are you using a different path?

Support alternative Emblem.js file extensions

or maaaaybe we should deprecate our Emblem support 😅

Update gRPC multixplex example for axum 0.7 and hyper 1

in https://github.com/tokio-rs/axum/pull/3105 it was decided to remove the gRPC example and potentially keep it in a different and/or dedicated repository. since the example was removed I guess we can close...

Tests for embroider?

the same way?

Uncaught DOMException: Failed to execute 'insertBefore' on 'Node'

since the addon doesn't perform any changes at runtime and only changes whitespace at buildtime, I'm not sure if/how this can be related 🤔

register the plugin using setupPreprocessorRegistry hook

CI should be fixed now. can you rebase? 🙏

register the plugin using setupPreprocessorRegistry hook

I'm a bit worried about this PR due to https://github.com/simplabs/ember-test-selectors/pull/359 🤔

Clarify the way forward

my issue with that is that as soon as you install the addon, you don't have any deprecation warnings for `this.$()` anymore, which would help you to at some point...