ember-cli
run `npm test` instead of `ember test` by default
Since the default blueprint for addons now runs ember test instead of ember try:each for npm test, I think this should be the new default.
If someone customizes their "test" script, for example changing it to ember exam, their travis run is now out of sync. They would have to remember to go into ".travis.yml" and change to
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO --skip-cleanup --- npm test
to keep them in sync. I think we should do this for them.
Codecov Report
:exclamation: No coverage uploaded for pull request base (
master@fd7b663). Click here to learn what that means. The diff coverage is100%.
@@ Coverage Diff @@
## master #192 +/- ##
=========================================
Coverage ? 93.76%
=========================================
Files ? 16
Lines ? 513
Branches ? 0
=========================================
Hits ? 481
Misses ? 32
Partials ? 0
| Impacted Files | Coverage Δ | |
|---|---|---|
| lib/commands/try-each.js | 100% <ø> (ø) |
|
| lib/commands/try-one.js | 100% <ø> (ø) |
|
| lib/commands/try-ember.js | 100% <ø> (ø) |
|
| lib/tasks/try-each.js | 84.7% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update fd7b663...1728c07. Read the comment docs.
this looks like a breaking change to me. for someone on an older version of the addon blueprint it would recursively run ember-try then 🤔
I also agree that it is a breaking change. However, the latest release is a beta of a major version bump.
Do we require npm to be available as a global even for yarn users?
I think so, but we should probably use yarn test if useYarn is true.
@kellyselden - Have any time to rebase this and make that tweak?
