Yslan Ramos

Results 11 comments of Yslan Ramos

https://github.com/entria/graphql-mongo-helpers/blob/master/src/connectionDefinitions.ts#L152 why on interfaces has ConnectionInterface? @sibelius

this PR depends on the #248 for lack of attention on my part. I don't have enough knowledge to use rebase :(

Suggestion 1, https://github.com/entria/graphql-mongo-helpers/blob/master/src/createLoader.ts#L80 `context.dataloaders[loaderName]` here it's get from the context, instead it's get direct of createLoader function internally Suggestion 2, ```ts createLoader({ name: 'UserLoader', getLoader: (ctx) => ctx.userLoader; // here...

i didn't understand the need of context loaders, maybe how it's currently is the best way

> tests? sure, I will add later

> @Tsugami Did you finish the tests or or are you going to add more for @sibelius to review later? It's been a long time, from what I've read, I...

this pr does much more than add tests for my changes, it is also setup the integration testing with mongo in memory, and the setup not working, its not connecting...

JSDoc is the best docs for a lib, you can adds: examples, tips, descriptions and links.

the same problem occurred to me some time ago, I don't remember how I solved it.