graphql-mongo-helpers icon indicating copy to clipboard operation
graphql-mongo-helpers copied to clipboard

fix: direction enum order

Open Tsugami opened this issue 2 years ago • 4 comments

Tsugami avatar Nov 09 '21 22:11 Tsugami

tests?

sure, I will add later

Tsugami avatar Nov 09 '21 22:11 Tsugami

@Tsugami Did you finish the tests or or are you going to add more for @sibelius to review later?

italosantana avatar Apr 20 '22 22:04 italosantana

@Tsugami Did you finish the tests or or are you going to add more for @sibelius to review later?

It's been a long time, from what I've read, I wrote the tests, I don't remember why I didn't take the pr from the draft, I'll fix the conflicts and run the tests here to see its ok

Tsugami avatar Apr 21 '22 18:04 Tsugami

this pr does much more than add tests for my changes, it is also setup the integration testing with mongo in memory, and the setup not working, its not connecting the database in memory, that's why it didn't merge before

I don't know how to solve it, I think it's better to revert to fist commit and setup integration tests in other pr

and too, other changes were made in period this pr, and when I merge, other tests broke

Tsugami avatar Apr 22 '22 13:04 Tsugami