nodejs
remove macOS for most projects
Refs: https://github.com/nodejs/citgm/pull/959#issuecomment-1712542947
Checklist
- [x]
npm testpasses - [ ] tests are included
- [ ] documentation is changed or added
- [x] contribution guidelines followed here
It's a temporary change, right?
Yes, the idea is to restore them one by one over the time
Codecov Report
Patch and project coverage have no change.
Comparison is base (
2baac2e) 96.44% compared to head (1fc650b) 96.44%.
Additional details and impacted files
@@ Coverage Diff @@
## main #971 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 28 28
Lines 2139 2139
=======================================
Hits 2063 2063
Misses 76 76
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
macOS hasn't run on any of the last 4 or 5 CITGM runs in Jenkins. Is that something intentional that someone did or is that a strange anomaly to be looked at?
(It last ran as part of https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3252/ but we're up to https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3257/ now and they all completed without a macOS job.)
macOS hasn't run on any of the last 4 or 5 CITGM runs in Jenkins. Is that something intentional that someone did or is that a strange anomaly to be looked at?
Ah that's probably https://github.com/nodejs/build/pull/3452 -- we no longer run on macOS 10.15 for Node.js 21 (i.e. main) and haven't added a newer macOS to the matrix for the CITGM job -- @UlisesGascon do you think we have the space on the macOS 11 VMs to add an additional Jenkins workspace (for the CITGM job)?
Ah that's probably https://github.com/nodejs/build/pull/3452 -- we no longer run on macOS 10.15 for Node.js 21 (i.e. main) and haven't added a newer macOS to the matrix for the CITGM job -- @UlisesGascon do you think we have the space on the macOS 11 VMs to add an additional Jenkins workspace (for the CITGM job)?
Yes, I think we can use one slot for it in Orka, based on this comment we can use macpro-4 to host it.
@UlisesGascon I was referring to extra disk space usage (for the citgm-smoker workspace), not additional VMs.
Based on https://github.com/nodejs/citgm/issues/997, maybe it's time to land this? @UlisesGascon If you want to rebase this, please do! (Otherwise, I'll do it at some point and force-push it to your branch. Either way!)