Alexandru Ionut Tripon

Results 304 comments of Alexandru Ionut Tripon

Also please fix this: https://github.com/PrismLauncher/PrismLauncher/pull/2875/checks?check_run_id=30913032067

Unrelated to all that function stuff: please be aware that we require you to sign your commits see https://github.com/PrismLauncher/PrismLauncher/pull/2875/checks?check_run_id=33444544491

If we go that route then the command will not be expanded in the logs, as the sh will expand in itself. Also if we go that route should we...

> Hey, is there any update for this PR? The PR is ready, and it was ready for a long time. It just needs approval from another maintainer.

> Just a thought, but since we got that filtering there, it could be useful to have a way to copy it / write to file with the filters applied...

Things I need to revisit on this PR: ![image](https://github.com/user-attachments/assets/b4287ddf-1d84-44ed-9236-5997dea495d7)

@TheKodeToad will you approve if I move https://github.com/PrismLauncher/PrismLauncher/pull/1872/commits/f29f8bbbecf6e1bf1bd6699e80032ebed2000d8e in a separate PR?

The tab will be visible until you start the game. Right now if you open the edit window that tab is visible(for new instances that do not have the version...

Not really, it downloads but because it's async it is not instant resulting: - you open the window - if the file is not there download it - because we...

Fixed following you suggestion TheKobeToad