Traumflug

Results 424 comments of Traumflug

Huh? A branch without tag or branch name? Not possible with Git's data structure. Looks like there's something wrong with gitk. Do you use Menu -> File -> Reload (Shift-F5)...

The 1000000 is to get microseconds. The 10 is to get transfered bytes from bit speed (8 data bits + 1 parity bit + some allowance). The 1 is to...

Yes, it can be a problem. If characters aren't written for some reason or another, such a loop would block forever. That's why I prefered the delay.

http://reprap.org/wiki/Step_rates#Measuring_step_rate

> At 91.6kHz it starts to accelerate and decelerate twice. It starts and accelerate to 91.6kHz. After that it restart with accelerating just to 4kHz. A typical example for overload....

Yes, volatile is a good idea :-) Now the question is, how move_state.step_no gets smaller. Shouldn't happen, there's only a `move_state.step_no++;` in dda_step(), no decrement. Possible bugs include an overflow...

> I've tested moves longer than 2000mm. Oh, didn't think of this. My review against overflows always assumed a max. travel distance of 1000 mm, so overflows on larger distances...

> The minimum size of this printer must be >1.3m. Looks like a code audit is required to squeeze the last few bits out of 32-bit signed integers. And/or to...

> Or by simple testing long moves There are occasions where the total distance from origin is calculated. For example, dda.c, line 190ff. > it's unsigned already. Yes, this part....

Sounds like this one: https://github.com/Traumflug/Teacup_Firmware/commit/77630167e7983387d7e66142914a6e55fd2f5953 This is on _master_, some 40 commits back, before _arm-ports-start-here_.