William Zijie Zhang

Results 160 comments of William Zijie Zhang

@purva-thakre sorry for the delayed response. I thought there were some type annotations missing, but I don't believe they are as important, atleast for the moment being. I will try...

Should be closed in #2585 , thanks for raising this @jonathanberthias . I initially didn't know why this was happening, but now we realized that we deleted action config behavior...

Hello @jusevitch I tried running both the code snippet above and the one in cvxpylayers on my MacOS M2 pro and didn't get any such errors. Could you post the...

I digged a bit into this and it seems like both ``geo_mean`` and ``inv_pos`` are not able to deal with scalar inputs. A fix in the source code of ``atoms/inv_prod.py``...

Is the exception implemented though? I tried the following test but it doesn't seem to pass :( ```py def test_geo_mean_exception(self) -> None: x = cp.Variable(1, pos=True) p = [1] expr...

LGTM. Just one quick question, is the flag ``-Wunused-but-set-variable`` like a sort of linter for cpp? I'm wondering if we should add that flag when building cvxcore? If so, it...

hello @Jiang22s yes definitely. Feel free to ask any questions here or on our discord. For this issue you would need to update the docstrings defined for each atom (located...

@trivial16 thanks for raising this issue. It is indeed really odd. Unfortunately there are way too many changes from version 0.4.11 to 1.6 to pinpoint exactly where this issue is...

Thanks for this feature request @TimWalter , it does sound really interesting! However, it is a bit unclear what we would need to add to support this. Could you provide...

> This may do the trick here as well? > > https://github.com/cvxpy/cvxpy/blob/096bdf1eb7c05e6c88d24d8435dceae2a2d1f816/.github/workflows/build.yml#L139 Do you mean adding the changes in that PR ([cvxpy#2054](https://github.com/cvxpy/cvxpy/pull/2054/files)) to the scs CI? If so, I think...