William Zijie Zhang

Results 160 comments of William Zijie Zhang

Hey @dschult I was wondering if you could take a look at this PR again. (sorry for pressing you) On my end the code is looking ready for merging. I...

Hey Dan, thanks for another round of review again. I made some changes to the code but I think I still need to go over the optimization you mentioned for...

> > As for separating the first function into two different ones (one for broadcast centre and one for broadcast time) if there is no way to decouple them nicely,...

I agree with you that the notation is a bit confusing since we use ``minimum broadcast time``. and by definition the ``broadcast time`` of a vertex already refers to the...

@dschult Sorry for another ping. However, as the semester is coming to an end for me, I would like you to review the comments I made on notation and the...

> Why are these in the `approximation` subfolder? It seems like these are exact methods -- not approximations. You aren't iterating over some approximate method getting closer to the actual...

Hey @dschult thank you so much again for your review. I have tried to generate the docs but don't seem to see the broadcasting subpage in the algorithms section. Could...

> Should we use the word "graph" or "tree" in the docs. The function works for trees. Do the framework and definitions work for regular graphs too? It seems to...

I was interested into diving into some GUI, potentially working on issue #391 later on. I started to look into the map_gui crate and wasn't completely sure what was going...

I will add some tasks for each subdirectory along with the docs. I could definitely help you with this as I document my process of learning some of the crates...