William Zijie Zhang

Results 160 comments of William Zijie Zhang

the pr_benchmark workflow is failing because the actions repo is still using python3.9, @SteveDiamond could you merge this PR in the actions repo please? https://github.com/cvxpy/actions/pull/23.

@phschiele @parthb83 sorry for the ping, but just wanted to let you know that the pr benchmark comment that you worked on are back :).

@PTNobel @SteveDiamond I think it makes sense to merge this ahead of 1.7. The versions 1.6.x will still support 3.9, but I don't think any versions in 1.7.x should support...

> This seems like a really small change, is there a reason to do it now? I think we should be close to ready for 1.7.0, and I feel like...

@PTNobel @SteveDiamond should we merge this? I'll make another PR to bump NumPy and then we can probably merge #2825

> ## Description > This is an unsolicited proposal. I am curious what you think and whether there is a cleaner and more automatic way to do this. > I...

I am not too familiar with Ruff format, does it make changes on all the files or only those that have changes in the pre-commit? Also, feel free to open...

it might be good to add a test also. To ensure that the code snippet from the original issue doesn't fail.

> Hmmm looks like our build process doesn't support rc releases because of a conda issue. We should see if there's a conda channel with rcs and/or migrate to pipx...