Tory9
Tory9
@peterbarker , thank you for a detailed review. I have considered your suggestions and applied some changes. I have a question about streaming this message by default. Since I'm new...
Hello @peterbarker, I was thinking about the issue of memory being occupied by this feature even if it's not used, which is a problem for boards with smaller flash memory....
@peterbarker This is an old PR opened by a former Septentrio intern. I based this PR on it but had to create a fresh one. You can safely close that...
Hey! The GPS_SYSTEM_ERROR_SOFTWARE error is coming from the ReceiverStatus message's RxError field - specifically the SOFTWARE bit, which is set upon detection of a software warning or error. To reset...
Regarding renaming GPS_JAMMING_STATE_OK to GPS_JAMMING_STATE_NOT_JAMMED, I agree this would probably make more sense. I'm not sure how exactly the naming was chosen because the MAVLink message was developed a while...
Hi, thank you for the review. I have applied the suggestions. I want to address two things: 1. Logging of internal errors: I tested the feature with Mosaic X5 and...
@hamishwillee Sounds good. Do you think it would make sense for me to first join one of the MAVLink Coordination Calls to discuss a clearer naming (and check if any...
@peterbarker @hamishwillee Hi, I’ve opened a PR with the suggested naming changes. I’m wondering whether that MAVLink PR will block this one from moving forward, or we still can finalize...
@peterbarker Hi! In the latest commits I updated the data transmission to send from all GPS instances that support this message. I also attempted to align the naming with the...
Hi @hamishwillee, @mrpollo , i will fix these over the weekend and let you know that its done