Torkel Loman

Results 439 comments of Torkel Loman

Your comments should be fixed. I have also updated to check that `@noise_scaling_parameters` work in normal code, and that this can be used to create a programmatic network with scaling....

If it is desired behaviour I will do the second one with ```julia η_stored = :η @variables t @species X1(t) X2(t) ηs = @noise_scaling_parameters $(η_stored)=0.0 @parameters k1 k2 r1 =...

Since we are more or less set on syntax, I have rewritten the noise scaling documentation given this update. I have also: - Updated the test as described. - Added...

> Many of the tests seem pretty removed from actually testing that the scaling is working. Is there not something more precise that could be tested? For example, manually creating...

Just want to point out that we never mix system and reaction level metadata, that is just a misunderstanding. The only case where we (currently) use reaction metadata is one...

This one shoudl also have better formatting and comments as compared to the previous PR.

See above responses. I will have another rearead through the doc thing. Generally, I didn't spend as much time on it as I should, because I had already had to...

> I thought spatially varying mass action jump rates are already supported? That is what a `SpatialMassActionJump` encodes. Ahh, didn't know that that was supported already.

I have renamed the "Correctness Tests" header. Good point of the coverage, the file wasn't being run but added now, thanks!

I just don't see why this specific thing should be a system transformation, and not: - Adding metadata to a system. - Adding default values to species/parameters - Specifying that...