Tommy Li comments

Results 187 comments of


                                            Tommy Li

chore: update KServe component to support 0.8.0

/lgtm @alembiewski I can open a separate PR to update the image tag if you are not able to verify the `quay.io/aipipeline/kserve-component:v0.8.0` image.

chore: update KServe component to support 0.8.0

/lgtm /approve

chore: update KServe component to support 0.8.0

/assign @animeshsingh @animeshsingh can you approve this PR? Thanks

bug(sdk) Double-looping over the same pipelineparam miscompiles

/assign

bug(sdk) Double-looping over the same pipelineparam miscompiles

Seems like this is a DSL level bug as the DSL make both it0 and it1 pointing to the same variable instead of copying it. This bug is also happening...

[wip] fix(pipelineloop): caching should include the params for making caching key.

Seems like the github actions weren't very stable since yesterday. My other PR was failing with network connection too.

[wip] fix(pipelineloop): caching should include the params for making caching key.

Thanks @ScrapCodes I verified the new code works with the new edge case and the product team is okay with the new mysql and gorm dependencies.

[wip] fix(pipelineloop): caching should include the params for making caching key.

/lgtm

fix(sdk): update loop dsl to handle same argument in nested loop

cc @Udiknedormin I have to change the way how the dsl name the argument in order to fix this issue. Let me know if you see any problem with this...

fix(sdk): update loop dsl to handle same argument in nested loop

@ScrapCodes for the sdk/python/tests/compiler/testdata/nested_loop_same_arg.yaml example, the pipeline loop cache hit triggered despite the argument is different in the next nested loop. I think your caching logic was based on the...