pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

chore: update KServe component to support 0.8.0

Open alembiewski opened this issue 3 years ago • 9 comments
trafficstars

Description of your changes: Update the Kserve pipeline component to support the latest release of kserve (0.8.0). Image available for testing: docker.io/mesosphere/kubeflow-dev:kserve-component-v0.8.0

Checklist:

alembiewski avatar Jun 08 '22 14:06 alembiewski

Hi @alembiewski. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Jun 08 '22 14:06 google-oss-prow[bot]

/ok-to-test

Tomcli avatar Jun 08 '22 16:06 Tomcli

Thanks @alembiewski, I also published the image to quay.io/aipipeline/kserve-component:v0.8.0. Do you want to also include the new tag for this PR?

Tomcli avatar Jun 10 '22 18:06 Tomcli

/lgtm @alembiewski I can open a separate PR to update the image tag if you are not able to verify the quay.io/aipipeline/kserve-component:v0.8.0 image.

Tomcli avatar Jun 15 '22 17:06 Tomcli

@Tomcli, I successfully tested the tag and I think it makes sense to update it in the scope of this PR

alembiewski avatar Jun 16 '22 11:06 alembiewski

/lgtm /approve

Tomcli avatar Jun 16 '22 16:06 Tomcli

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Tomcli To complete the pull request process, please assign animeshsingh after the PR has been reviewed. You can assign the PR to them by writing /assign @animeshsingh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Jun 16 '22 16:06 google-oss-prow[bot]

/assign @animeshsingh

@animeshsingh can you approve this PR? Thanks

Tomcli avatar Jun 16 '22 16:06 Tomcli

Any updates on this?

alembiewski avatar Aug 16 '22 13:08 alembiewski

@alembiewski i think this pr ready to merge, you should /approve in comment

juhyeon-cha avatar May 17 '23 00:05 juhyeon-cha

/approve

sorry I got approve permission few months after this. The image should be working for kserve 0.8.0.

Tomcli avatar May 17 '23 15:05 Tomcli

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar May 17 '23 15:05 google-oss-prow[bot]