kfp-tekton icon indicating copy to clipboard operation
kfp-tekton copied to clipboard

[wip] fix(pipelineloop): caching should include the params for making caching key.

Open ScrapCodes opened this issue 3 years ago • 1 comments

Which issue is resolved by this Pull Request: Resolves #1053

Description of your changes:

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

ScrapCodes avatar Oct 11 '22 17:10 ScrapCodes

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScrapCodes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Oct 11 '22 17:10 google-oss-prow[bot]

Hi @Tomcli, can you please take a look !

ScrapCodes avatar Oct 18 '22 16:10 ScrapCodes

/retest

ScrapCodes avatar Oct 19 '22 15:10 ScrapCodes

/test all

ScrapCodes avatar Oct 19 '22 15:10 ScrapCodes

Seems like the github actions weren't very stable since yesterday. My other PR was failing with network connection too.

Tomcli avatar Oct 19 '22 16:10 Tomcli

Thanks @ScrapCodes I verified the new code works with the new edge case and the product team is okay with the new mysql and gorm dependencies.

Tomcli avatar Oct 24 '22 21:10 Tomcli

/lgtm

Tomcli avatar Oct 24 '22 21:10 Tomcli