kfp-tekton
kfp-tekton copied to clipboard
[wip] fix(pipelineloop): caching should include the params for making caching key.
Which issue is resolved by this Pull Request: Resolves #1053
Description of your changes:
Environment tested:
- Python Version (use
python --version): - Tekton Version (use
tkn version): - Kubernetes Version (use
kubectl version): - OS (e.g. from
/etc/os-release):
Checklist:
- [ ] The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ScrapCodes
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [ScrapCodes]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @Tomcli, can you please take a look !
/retest
/test all
Seems like the github actions weren't very stable since yesterday. My other PR was failing with network connection too.
Thanks @ScrapCodes I verified the new code works with the new edge case and the product team is okay with the new mysql and gorm dependencies.
/lgtm