Tom Nicholas

Results 1090 comments of Tom Nicholas

Yeah 😕 - I raised #761 to track that. For this PR - how big is that file the test is now pointing to?

This would be useful on virtual datasets too.

This is probably a good idea. Questions: 1. Does the kerchunk backend for xarray support reading v3-format references? 2. Should we keep both? Selecting via a `zarr_format` kwarg that defaults...

I think we simply have not yet got around to implementing the `append_dim` or `group` kwargs on `VirtualiZarrDatasetAccessor.to_icechunk`, and you need both for your use case. If you're interested then...

If this is now the recommended syntax ```python fs = fsspec.filesystem("gs", asynchronous=True) zstore = zarr.storage.FsspecStore(fs, path="/cmip6/CMIP6/CMIP/NCAR/CESM2-FV2/historical/r2i1p1f1/Amon/tas/gn/v20200226/") ``` for creating a zarr store to interact with, then presumably that now means...

Note that if I change the compressors line to this then it works ```python compressors = [zarr.codecs.BloscCodec(cname="zstd", clevel=3, shuffle="shuffle")] ```

We really need this to work, because it's preventing people using this pattern to move their zarr v2 data into zarr v3 data via xarray: ```python ds = xr.open_zarr('store-v2.zarr') ds.to_zarr('store-v3.zarr')...

I think with #765 this issue will become obsolete? As then we will be compatible with the latest versions of both xarray and zarr.

It looks beautiful. There are some small things that could be improved, but I think you should merge. Thing that could be improved: The formatting of code examples doesn't make...