Tom Nicholas

Results 401 comments of Tom Nicholas

> Since `RaggedArray` can't be used everywhere that an `ak.Array` can be used, it shouldn't be a subclass. I see, makes sense. > I hadn't been thinking that RaggedArray is...

> Also on the digression, I just want to clarify where we're coming from, why we did the things we did. Very interesting @jpivarski - that would make a good...

> Can we xfail these new tests and merge for now? As long as tests/test_sparse.py still passes, there are no issues, correct? Yeah we now have [another array type](https://github.com/pydata/xarray/issues/6807) to...

I'm watching the progress of this PR with bated breath! I literally want to be able to test 3 different array libraries right now: [pint](https://github.com/pydata/xarray/issues/3594), [cubed](https://github.com/pydata/xarray/issues/6807), and [awkward](https://github.com/pydata/xarray/issues/4285). :exploding_head: Thinking...

See https://github.com/pydata/xarray/issues/6894 for general discussion of the general plans

Q: Shouldn't the base classes live in `xarray.testing` rather than `xarray.tests`? Then the `test_units.py` and `test_sparse.py` live in `xarray.tests` (until they eventually get moved to another repo), but import the...

> Q: Shouldn't the base classes live in xarray.testing rather than xarray.tests? Another Q on a similar note: Are we planning to eventually publicly expose the (awesome btw) strategies that...

> I also agree that both the strategies as well as the base classes should eventually live in xarray.testing, but I'd probably keep them in xarray.tests for now (just so...

> if we can get the strategies from https://github.com/pydata/xarray/pull/6908 to shrink well I think they already do shrink well. Each of them has corresponding unit tests, and none of those...

> should we skip PandasIndex and PandasMultiIndex? If we're [encouraging people to look at these / subclass them](https://github.com/pydata/xarray/issues/7031#issuecomment-1248259720) to create custom indexes, then they should have a repr too.