TomGoodIdea

Hope doesn't have the Uninhabited government, only the attribute, so it inherits the system's government (Republic and later FW).

I've just read the code that checks if you can land on a planet and it looks like it skips the required reputation completely if the planet has the `uninhabited`...

Implementing this wouldn't be too complicated, but: 1. it would probably reduce performance (especially in large battles), which means it would need to be disabled by default (a preference for...

@rovermicrover There are merge conflicts and unresolved comments from Lorantine. Are you still interested in working on this PR?

Implemented in https://github.com/endless-sky/endless-sky/commit/b9ec212ff9f1a0b806ce8550a2964b6788eca66c

> Are you at least able to take off and land to get the next mission to offer? Yes, departing and landing allows me to continue the storyline.

@MiscelaneousItem Are you able to update this anytime soon? If not, we'll close it so that someone can pick it up.

> Should I create a new PR for the updated version, as this is now significantly outdated ? Doesn't matter, do what's easier for you.

I was talking about this code: https://github.com/endless-sky/endless-sky/blob/26cd1c279fccd56116ce10146ff1ff05c4213fc5/source/PlanetPanel.cpp#L115-L126 So, the condition that checks if there's trade available on the planet would look like this: ``` planet.CanUseServices() && system.HasTrade() && planet.GetPort().HasService(Port::ServicesType::Trading) ```

If you turn the check into an `if(HasFailed(player)) return;` guard at the beginning, you don't need to change indentation of the whole function.