Vasek - Tom C

Results 236 comments of Vasek - Tom C

Few changes that we'll introduced on this PR based on my conversation with: - change `@context` to `@argument` with `default` and `ignore` metadata - support `ignore` as parameter - Move...

@helderco I've updated the PR with the new API and implement ignore. All point above has been implemented 🚀

> If I'm in a module in /foo (/ == git root) and the default path is /bar/man, the path is not resolved correctly: Could I also see the code...

Test are failing due to 2 Python errors: https://dagger.cloud/dagger/traces/04e8dd584b027109a12f120f41a0e209?span=f60a702af34c8c5f Nothing directly related to the PR, I can also see this issue on #7824

I continued your research based on your repro @jedevc and that's super weird. Here's the dump of some logs I get when I try your repro: During module loading: ```...

The function `getExplicitModuleSourceRef` is pretty small, I tried some changes but it didn't fixed the issue. It's related to where the user is, some buildkit func seems to depends on...

Ok so last friday we did a big exploration with @helderco to find the issue and it seems it's the related to the set of the `sourceRootSubPath` when calling `ResolveFromCaller`...

The fails in the CI doesn't seem related to my PR, more flackiness: - https://dagger.cloud/dagger/traces/c62c35a0fea4e7ee46b82e36677052de?span=2719a2b8918be39f#25daada6376b1058 - https://dagger.cloud/dagger/traces/c62c35a0fea4e7ee46b82e36677052de?span=2719a2b8918be39f#e3dca007344955fe About the Test important, I'm super confused about it https://dagger.cloud/dagger/traces/4a3b8d288d9af71bcda3004c4c4c8637#76074fdc7901bd68, the `test all`...

> There's an argument for doing blob conversion here in that it means contextual directories with equal contents will always be cached the same no matter their source. This can...

> I'm currently working on some performance improvements to module loading that will result in enough changes/simplifications to the relevant code that I'm just going to rope this in. Re-assigning...