Vasek - Tom C
Vasek - Tom C
> Yarn patches typescript I believe. Although I never looked into what it actually changed Yeah, that's quite strange... but at least this PR will improve the DX :D
@helderco I did some improvement in the PR to improve the code readability and steps. I now store module related config in `moduleConfig` so it's easier to reuse everywhere. For...
These fails does not seem related to my changes: - https://dagger.cloud/dagger/traces/e4fb71cfddfef048d2640175db7aef2c?span=e436aeeb2d3b40bd - https://dagger.cloud/dagger/traces/e4fb71cfddfef048d2640175db7aef2c?span=af15197047f1972e#383ca90d4a057a5e So I think the PR is ready for another review
@helderco I need to ignore `node_modules`before merging the PR, otherwise it makes the TS SDK much slower EDIT: I'm holding this PR until I successfully improve performances, I think it's...
@helderco I finally found a way to remove the `node_modules` upload, it makes the SDK a bit faster, I like it a lot! I'll also try to remove the duplication...
Thanks for your feedbacks! > You must assume there's a package.json at the top-level directory (above the dagger/ folder) The module init creates a `package.json` and it's pretty much required...
> Because we're going to be using this in our CI/CD pipeline, and that's the best practice. What I'm including above (.withExec(['yarn', 'install', '--immutable']) will be how many projects will...
> so the error still occurs. I think this is due to the SDK's yarn install (v1 will modify the lock file), and then my yarn install --immutable will fail...
Found a new issue by not installing the SDK node_modules in the runtime, it seems the subpackage that sdk depends on are not added to the lockfile, I don't understand...
> Also since there isn't a .yarnrc.yml file in the sdk, it will use PnP instead of the node modules linker which would cause other issues. Yes, I'm currently trying...