Vasek - Tom C
Vasek - Tom C
> Have you thought of using [JSDoc](https://jsdoc.app/) for some of this? This is already used in the JS/TS ecosystem to provide more information about types / properties I have never...
> Using JSDoc has the added benefit of being read by IDEs, so that would provide a much nicer DX Okay! That's nice topic to discuss on the community call,...
I'm closing this issue since we're not planning to work on this issue in the nexts months, we'll reopen it if we decide to drop decorators in favor of JSDoc...
Hey thanks for the reminder. This has already been done by #9531 (see: https://github.com/dagger/dagger/commit/09acd855c8d3b5a20bb6c2163baa20dfe6345d99#diff-1097377c78d22400c9189626a6f2d209142a89cc652ea050fb577aa1087634e0) So I can close this PR since it doesn't introduce a change anymore.
@jholm117 I see that the `helm` CI job is failing, this need to be fixed before merging ;)
> Okay think I fixed the lint error. The check says timeout on this page, but on the Checks page it looks like it succeeded? Yeah looks good, I retriggered...
> I have a decent environment setup using vscode. If anyone is interested, I can demo. It's set up using nx monorepo and a view vscode plugins. I could do...
> Any advice on finishing up the PR would be appreciated, I'll look at the changie stuff and commit that shortly. Hey, based on the changes that I'm seeing, you...
> @TomChv the command you gave me all passes locally. I still see some things failing on this PR but from what I can see it's unrelated to the PR....
LGTM, merge it when CI's green