[Typescript SDK] Add @opentelemetry/core to package dependencies

Open jholm117 opened this issue 1 year ago • 1 comments

This package was not declared in the package.json so I was seeing a corresponding runtime error. The package was already available via transitive dependencies so in less strict environments it probably hasn't been an issue.

The package is directly imported here: https://github.com/dagger/dagger/blob/main/sdk/typescript/src/telemetry/init.ts#L1

Feb 21 '25 17:02 jholm117

Hey @TomChv any chance I could get a review? Looks like you've been tagged

Mar 11 '25 22:03 jholm117

Hey thanks for the reminder.

This has already been done by #9531 (see: https://github.com/dagger/dagger/commit/09acd855c8d3b5a20bb6c2163baa20dfe6345d99#diff-1097377c78d22400c9189626a6f2d209142a89cc652ea050fb577aa1087634e0)

So I can close this PR since it doesn't introduce a change anymore.

Mar 17 '25 13:03 TomChv