Toby Harradine

Results 9 comments of Toby Harradine

I agree this shouldn't be done in micro releases, only minor. The problem is that Python doesn't have a package-protected scope, only module/class/subclass protected. So I'd prefer leaving them as...

Like I know that encapsulation in Python is only really by convention with leading underscores, but I would argue that a single leading underscore on a module-level function implies module-level...

I'm certainly a fan of this idea, and made a similar [comment](https://github.com/python-poetry/poetry/issues/1307#issuecomment-674336917) regarding that "Applications are not distributed via wheels" argument on the original issue.

It's fine, I totally understand :)

I like the suggestion, I've always wanted to write this cog, and have never got around to it. However, I want us to be careful, since as it stands alias...

Hey @TrustyJAID, this looks awesome! Thanks for opening the issue. I'd be grateful for a PR with these changes :)

Try setting the downvote emoji again, sometimes this seems to fix issues where votes aren't being detected.

Not much I can do without more info. What are the emojis?

I'll look into it! I haven't touched that cog since August 2017, apart from accounting for breaking changes :joy: