Dominik Dorfmeister

Results 453 comments of Dominik Dorfmeister

devtools are browser specific. why would you import them in node?

okay it seems that node picks up the esm build even though it cannot import esm? I'm lost with all of these bundlers / ways to import things lol. I...

I'll leave this to the experts @DamianOsipiuk @sachinraja

@sventschui this works for me now in `v4.3.0-beta.3` - https://github.com/TanStack/query/releases/tag/v4.3.0-beta.3 ``` Welcome to Node.js v16.13.0. Type ".help" for more information. > import("@tanstack/react-query-devtools") Promise { , [Symbol(async_id_symbol)]: 26, [Symbol(trigger_async_id_symbol)]: 5, [Symbol(destroyed)]:...

this will likely conflict with: - https://github.com/TanStack/query/pull/4011

thanks for the contribution. It's fine, I'll merge and we'll solve the conflicts on the other PR :)

@JohnDaly we want to release all build related things in a pre-release version. There is also this PR that re-adds proper ESM support: - https://github.com/TanStack/query/pull/3892 both of them should go...

@JohnDaly it seems that this PR increased the bundle-size of react-query by 5x 😅 https://bundlephobia.com/package/@tanstack/[email protected] We can also see this in the bundlewatch logs: `packages/react-query/build/umd/index.production.js: 43.89KB (gzip)` size on main...

a similar PR was just merged, please address the conflicts and the above comment, thanks.

> Is it reasonable to ask you to add react as a peer dependency within this package.json file? yeah I think that's what we need to do, similar to how...