query icon indicating copy to clipboard operation
query copied to clipboard

chore(devtools): Add peerDependencies

Open doinki opened this issue 3 years ago • 2 comments

react-query-devtools gives the following error when using yarn berry workspace. And you can check it out at https://github.com/doinki/react-query

Screenshot from 2022-08-09 10-57-44

packageExtensions:
  '@tanstack/react-query-devtools@*':
    peerDependencies:
      '@tanstack/react-query': '^4.0.0'

But can fix this error by adding packageExtentions to .yarnrc.yml

doinki avatar Aug 09 '22 02:08 doinki

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ba3ba271a45a0b2fd8b796d162bd1b5e60a313c6:

Sandbox Source
@tanstack/query-example-react-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration

codesandbox-ci[bot] avatar Aug 09 '22 02:08 codesandbox-ci[bot]

#4004

doinki avatar Aug 10 '22 00:08 doinki

this will likely conflict with:

  • https://github.com/TanStack/query/pull/4011

TkDodo avatar Aug 11 '22 15:08 TkDodo

@TkDodo This is my first time making a pull request to open source, what should I do?

doinki avatar Aug 11 '22 15:08 doinki

thanks for the contribution. It's fine, I'll merge and we'll solve the conflicts on the other PR :)

TkDodo avatar Aug 11 '22 15:08 TkDodo