Timothy Mothra
Timothy Mothra
> We are also discussing if Extensions.Hosting should be part of this repo or should be "lift and shifted" to the -contrib repo. Just a minor comment: We're using the...
I saw this one today. Linux & NetCoreApp3.1 https://github.com/open-telemetry/opentelemetry-dotnet/runs/7505347817?check_suite_focus=true
Discussed in Community Meeting (2022-07-05). No objections. :)
Workflow definition: https://github.com/open-telemetry/opentelemetry-dotnet/blob/00af7817fdba22b2a5948e574c6769098003f682/.github/workflows/apicompatibility.yml#L13 Common.prod.props: https://github.com/open-telemetry/opentelemetry-dotnet/blob/252437d1ea37bb1a9f960a2941ab922ea5cc23d2/build/Common.prod.props#L19-L21 I see three different errors in the log: - New-Item > New-Item : An item with the specified name D:\a\opentelemetry-dotnet\opentelemetry-dotnet\src\LastMajorVersionBinaries already exists. https://github.com/open-telemetry/opentelemetry-dotnet/blob/8ca6574599cf412d732bac3fb46c515c746f15b8/build/PreBuild.ps1#L3-L8 I think...
This looks like the better option to me. Triggering the release from the Tag seems straight forward and less error prone.
Shared my findings in today's SIG meeting (2022-08-09). Will continue to work to improve code coverage, this will remove some of the variability. I'll also follow up with Eddy if...
The implementation looks good to me. Can you add any new tests that verify the Exception Telemetry?
@zakimaksyutov what is the priority (p1, p2, p3) and milestone for this (2.7, 2.8, later)
/AzurePipelines run
/AzurePipelines run