opentelemetry-dotnet icon indicating copy to clipboard operation
opentelemetry-dotnet copied to clipboard

Trigger pack and publish when release is created

Open alanwest opened this issue 2 years ago • 3 comments

I think I like this approach better than #3634.

The pack and publish job is kicked off automatically upon creating a release in GitHub.

Step 1 - Create and push the tags just as before. Then click create release here:

Screen Shot 2022-09-07 at 4 10 50 PM

Step 2 - Fill out the details of the release as usual:

Screen Shot 2022-09-07 at 4 12 34 PM

Step 3 - Click "Publish release" and the job is kicked off like so:

Screen Shot 2022-09-07 at 4 13 25 PM

alanwest avatar Sep 07 '22 23:09 alanwest

Codecov Report

Merging #3638 (7fa0c94) into main (d10f1f9) will decrease coverage by 0.22%. The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3638      +/-   ##
==========================================
- Coverage   87.80%   87.58%   -0.23%     
==========================================
  Files         283      283              
  Lines       10308    10308              
==========================================
- Hits         9051     9028      -23     
- Misses       1257     1280      +23     
Impacted Files Coverage Δ
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 35.71% <0.00%> (-42.86%) :arrow_down:
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 36.36% <0.00%> (-40.91%) :arrow_down:
...tation/OpenTelemetryProtocolExporterEventSource.cs 75.00% <0.00%> (-10.00%) :arrow_down:
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) :arrow_down:
...metryProtocol/Implementation/ActivityExtensions.cs 91.75% <0.00%> (-3.30%) :arrow_down:
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) :arrow_down:
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (+2.94%) :arrow_up:
...Propagators/OpenTelemetryPropagatorsEventSource.cs 100.00% <0.00%> (+12.50%) :arrow_up:

codecov[bot] avatar Sep 07 '22 23:09 codecov[bot]

This looks like the better option to me. Triggering the release from the Tag seems straight forward and less error prone.

TimothyMothra avatar Sep 07 '22 23:09 TimothyMothra

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

github-actions[bot] avatar Sep 16 '22 04:09 github-actions[bot]

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

github-actions[bot] avatar Sep 27 '22 03:09 github-actions[bot]