Tim Düsterhus

Consistently use (User)Option::getTitle()

2

The `getTitle()` method was added in a41ce9459e97d83a620d5c3743907f4850f35eb5, but was not consistently used. It's missing from `optionFieldList.tpl` for starters: https://github.com/WoltLab/WCF/blob/c29b75e0e43c5680f7d4182325b5958902997661/com.woltlab.wcf/templates/optionFieldList.tpl#L10 All occurrences can probably be found by searching for `wcf.user.option.`.

Add explicit PRIMARY KEY for select heavy tables with a multi-column UNIQUE KEY

12

InnoDB uses the PRIMARY KEY as the clustered index for the btree. Without an explicit PRIMARY KEY an internal auto increment will be used, allowing the best INSERT performance because...

see https://community.woltlab.com/thread/291893-formbutton-templateapplication-fehlt/?postID=1863502#post1863502

Autogenerated names for database indices are pretty messy, because the legacy API did not handle them consistently depending on whether the INDEX was included in the initial `CREATE TABLE` (unnamed,...

- [ ] Take the package ID as a parameter. - [ ] Possibly allow bulk deletions.

Inheriting from controllers is a mess. see #4550

- [ ] Untangle this from RegisterNewActivationCodeForm. see: 238adcfc6e94778b42e68521b3be4cb9a43c94bc - [ ] Adjust this to make use of a secure reactivation code, similar to the initial activation code.

confirmTime in wcf1_user_notification's (userID, eventID, objectID, confirmTime) INDEX appears to be useless

2

I was unable to find a query that would be able to leverage the existence of the `confirmTime` as part of that index. All queries involving `confirmTime` do not involve...