Tim Düsterhus
Tim Düsterhus
The reauthentication's grace period is meant to improve the UX in cases where a user opens up a form shortly before the soft limit expires and then submits the form...
- [ ] Remove use of DirectoryUtil. - [ ] Make the cache files `return;` the serialized data, instead of needing to manually parse them (in preliminary tests this brings...
https://github.com/WoltLab/WCF/blob/dd19073b48016b8aa4fd299fa676c54b96c8af64/wcfsetup/install/files/lib/system/WCF.class.php#L897 Various classes do not yet have a proper return type, but the deprecation error was suppressed by the `@`. This should be tested once more without the `@` to...
we currently have: - ``: https://github.com/WoltLab/WCF/blob/ce4b59bfbf770fb5a88105fd3205f60ea6039181/wcfsetup/install/files/lib/acp/form/LanguageImportForm.class.php#L174 - `strcmp`: https://github.com/WoltLab/WCF/blob/ce4b59bfbf770fb5a88105fd3205f60ea6039181/wcfsetup/install/files/lib/acp/form/BoxAddForm.class.php#L267-L270 - `strcasecmp`: https://github.com/WoltLab/WCF/blob/ce4b59bfbf770fb5a88105fd3205f60ea6039181/wcfsetup/install/files/lib/acp/form/DataImportForm.class.php#L138-L141 They should all be unified to use ``. `strcmp` is a direct replacement. `strcasecmp` will need to either...
Use `` where possible. Affected locations can somewhat easily be found by searching for `return -1` which is fairly specific for this type of callback.
e.g. for use in https://github.com/WoltLab/WCF/blob/e6aaee42d458378064d472a30a9b97b3af6f3335/wcfsetup/install/files/lib/system/event/EventHandler.class.php#L143 to make the `catch` in b4db5a5c6eddf270b6f6e779a88656e7b805cb12 more specific.
see https://github.com/WoltLab/WCF/pull/4639#issuecomment-1022079396
A post like: ``` @test test ``` will render as: ``` test test ``` It works fine for the `text/html` version.