azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Published
20 hours ago •
Azure
Azure
[CDN] 2022-11-01-preview
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [x] new API version
- [ ] update existing version for new feature
- [ ] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
- By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
Contribution checklist (MS Employees Only):
- [ ] I commit to follow the Breaking Change Policy of "no breaking changes"
- [ ] I have reviewed the documentation for the workflow.
- [ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
-
[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.
Hi, @ChenglongLiu Thanks for your PR. I am workflow bot for review process. Here are some small tips.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 5 Errors, 5 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.1)] | new version | base version |
|---|---|---|
| afdx.json | 2022-11-01-preview(98c0bbc) | 2021-06-01(main) |
| afdx.json | 2022-11-01-preview(98c0bbc) | 2022-05-01-preview(main) |
| cdn.json | 2022-11-01-preview(98c0bbc) | 2021-06-01(main) |
| cdn.json | 2022-11-01-preview(98c0bbc) | 2022-05-01-preview(main) |
| cdnwebapplicationfirewall.json | 2022-11-01-preview(98c0bbc) | 2021-06-01(main) |
| cdnwebapplicationfirewall.json | 2022-11-01-preview(98c0bbc) | 2022-05-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Cdn/validateSecret' removed or restructured? Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L3242:5 |
|
The new version adds a x-ms-enum extension. New: Microsoft.Cdn/preview/2022-11-01-preview/afdx.json#L5732:9 Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L5487:9 |
|
The new version adds a x-ms-enum extension. New: Microsoft.Cdn/preview/2022-11-01-preview/afdx.json#L5752:15 Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L5503:15 |
|
The new version adds a x-ms-enum extension. New: Microsoft.Cdn/preview/2022-11-01-preview/afdx.json#L5965:9 Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L5712:9 |
|
The new version adds a x-ms-enum extension. New: Microsoft.Cdn/preview/2022-11-01-preview/afdx.json#L5985:15 Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L5728:15 |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-preview-2022-11 | package-preview-2022-11(98c0bbc) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3695 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3695 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3695 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3741 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3741 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3741 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3772 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3772 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3772 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3794 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3794 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3794 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3847 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3847 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3847 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3904 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3904 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3904 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3957 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3957 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3957 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4014 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4014 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4014 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4067 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4067 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4067 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4073 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4073 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4073 |
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag. readme: specification/cdn/resource-manager/readme.md json: Microsoft.Cdn/preview/2022-05-01-preview/afdx.json |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
Validation passes for ServiceAPIReadinessTest.
️❌ModelValidation: 52 Errors, 0 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go - sdk/resourcemanager/cdn/armcdn - Approved - 2.0.0-beta.1+ Const `MetricsResponseGranularityP1D` has been removed + Const `MetricsResponseGranularityPT1H` has been removed + Const `MetricsResponseGranularityPT5M` has been removed + Const `MetricsResponseSeriesItemUnitBitsPerSecond` has been removed + Const `MetricsResponseSeriesItemUnitBytes` has been removed + Const `MetricsResponseSeriesItemUnitCount` has been removed + Const `MetricsResponseSeriesItemUnitMilliSeconds` has been removed + Const `WafMetricsResponseGranularityP1D` has been removed + Const `WafMetricsResponseGranularityPT1H` has been removed + Const `WafMetricsResponseGranularityPT5M` has been removed + Const `WafMetricsResponseSeriesItemUnitCount` has been removed + Function `*CustomDomainsClient.DisableCustomHTTPS` has been removed + Function `*CustomDomainsClient.EnableCustomHTTPS` has been removed + Function `*ValidateClient.Secret` has been removed + Function `NewValidateClient` has been removed + Function `PossibleMetricsResponseGranularityValues` has been removed + Function `PossibleMetricsResponseSeriesItemUnitValues` has been removed + Function `PossibleWafMetricsResponseGranularityValues` has been removed + Function `PossibleWafMetricsResponseSeriesItemUnitValues` has been removed + Struct `CustomDomainsClientDisableCustomHTTPSOptions` has been removed + Struct `CustomDomainsClientEnableCustomHTTPSOptions` has been removed + Struct `ValidateClientSecretOptions` has been removed + Struct `ValidateClientSecretResponse` has been removed + Struct `ValidateClient` has been removed + Type alias `MetricsResponseGranularity` has been removed + Type alias `MetricsResponseSeriesItemUnit` has been removed + Type alias `WafMetricsResponseGranularity` has been removed + Type alias `WafMetricsResponseSeriesItemUnit` has been removed + Type of `EndpointProperties.CustomDomains` has been changed from `[]*CustomDomain` to `[]*DeepCreatedCustomDomain` + Type of `MetricsResponse.Granularity` has been changed from `*MetricsResponseGranularity` to `*MetricsGranularity` + Type of `MetricsResponseSeriesItem.Unit` has been changed from `*MetricsResponseSeriesItemUnit` to `*MetricsSeriesUnit` + Type of `WafMetricsResponse.Granularity` has been changed from `*WafMetricsResponseGranularity` to `*WafMetricsGranularity` + Type of `WafMetricsResponseSeriesItem.Unit` has been changed from `*WafMetricsResponseSeriesItemUnit` to `*WafMetricsSeriesUnit`
❌azure-sdk-for-python-track2 - track2_azure-mgmt-cdn - Approved - 12.1.0b1+ Removed operation group ValidateOperations
❌azure-sdk-for-js - @azure/arm-cdn - Approved - 8.0.0-beta.1+ Class CdnManagementClient no longer has parameter validate + Removed Enum KnownMetricsResponseGranularity + Removed Enum KnownMetricsResponseSeriesItemUnit + Removed Enum KnownWafMetricsResponseGranularity + Removed operation group Validate
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs]Release - Generate from 4903b1ed79e30f689d7c469cfa06734cfcd106d6. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] npm notice New patch version of npm available! 8.19.2 -> 8.19.3 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.19.3> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-cdn [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation AFDProfilesOperations.begin_upgrade info [Changelog] - Added operation AFDProfilesOperations.validate_secret info [Changelog] - Added operation ProfilesOperations.begin_migrate info [Changelog] - Added operation ProfilesOperations.begin_migration_commit info [Changelog] - Added operation ProfilesOperations.can_migrate info [Changelog] - Model AFDDomain has a new parameter extended_properties info [Changelog] - Model AFDDomainProperties has a new parameter extended_properties info [Changelog] - Model CdnWebApplicationFirewallPolicy has a new parameter extended_properties info [Changelog] - Model Profile has a new parameter extended_properties info [Changelog] - Model Profile has a new parameter identity info [Changelog] - Model ProfileUpdateParameters has a new parameter identity info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Removed operation group ValidateOperations
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs]Release - Generate from 4903b1ed79e30f689d7c469cfa06734cfcd106d6. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json warn No file changes detected after generation warn No package detected after generation
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from 4903b1ed79e30f689d7c469cfa06734cfcd106d6. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/cdn/armcdn [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Type of `WafMetricsResponseSeriesItem.Unit` has been changed from `*WafMetricsResponseSeriesItemUnit` to `*WafMetricsSeriesUnit` info [Changelog] - Type of `EndpointProperties.CustomDomains` has been changed from `[]*CustomDomain` to `[]*DeepCreatedCustomDomain` info [Changelog] - Type of `MetricsResponse.Granularity` has been changed from `*MetricsResponseGranularity` to `*MetricsGranularity` info [Changelog] - Type of `MetricsResponseSeriesItem.Unit` has been changed from `*MetricsResponseSeriesItemUnit` to `*MetricsSeriesUnit` info [Changelog] - Type of `WafMetricsResponse.Granularity` has been changed from `*WafMetricsResponseGranularity` to `*WafMetricsGranularity` info [Changelog] - Const `MetricsResponseSeriesItemUnitMilliSeconds` has been removed info [Changelog] - Const `WafMetricsResponseGranularityPT5M` has been removed info [Changelog] - Const `MetricsResponseGranularityPT5M` has been removed info [Changelog] - Const `WafMetricsResponseSeriesItemUnitCount` has been removed info [Changelog] - Const `MetricsResponseGranularityPT1H` has been removed info [Changelog] - Const `WafMetricsResponseGranularityP1D` has been removed info [Changelog] - Const `WafMetricsResponseGranularityPT1H` has been removed info [Changelog] - Const `MetricsResponseSeriesItemUnitBytes` has been removed info [Changelog] - Const `MetricsResponseSeriesItemUnitBitsPerSecond` has been removed info [Changelog] - Const `MetricsResponseSeriesItemUnitCount` has been removed info [Changelog] - Const `MetricsResponseGranularityP1D` has been removed info [Changelog] - Type alias `MetricsResponseSeriesItemUnit` has been removed info [Changelog] - Type alias `MetricsResponseGranularity` has been removed info [Changelog] - Type alias `WafMetricsResponseGranularity` has been removed info [Changelog] - Type alias `WafMetricsResponseSeriesItemUnit` has been removed info [Changelog] - Function `PossibleMetricsResponseGranularityValues` has been removed info [Changelog] - Function `PossibleWafMetricsResponseSeriesItemUnitValues` has been removed info [Changelog] - Function `*ValidateClient.Secret` has been removed info [Changelog] - Function `PossibleMetricsResponseSeriesItemUnitValues` has been removed info [Changelog] - Function `*CustomDomainsClient.EnableCustomHTTPS` has been removed info [Changelog] - Function `*CustomDomainsClient.DisableCustomHTTPS` has been removed info [Changelog] - Function `PossibleWafMetricsResponseGranularityValues` has been removed info [Changelog] - Function `NewValidateClient` has been removed info [Changelog] - Struct `CustomDomainsClientDisableCustomHTTPSOptions` has been removed info [Changelog] - Struct `CustomDomainsClientEnableCustomHTTPSOptions` has been removed info [Changelog] - Struct `ValidateClient` has been removed info [Changelog] - Struct `ValidateClientSecretOptions` has been removed info [Changelog] - Struct `ValidateClientSecretResponse` has been removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New const `MetricsGranularityPT5M` info [Changelog] - New const `ManagedServiceIdentityTypeUserAssigned` info [Changelog] - New const `WafMetricsSeriesUnitCount` info [Changelog] - New const `ProfileResourceStateAbortingMigration` info [Changelog] - New const `WafMetricsGranularityP1D` info [Changelog] - New const `CanMigrateDefaultSKUStandardAzureFrontDoor` info [Changelog] - New const `MetricsSeriesUnitBitsPerSecond` info [Changelog] - New const `WafMetricsGranularityPT1H` info [Changelog] - New const `ProfileResourceStatePendingMigrationCommit` info [Changelog] - New const `WafMetricsGranularityPT5M` info [Changelog] - New const `ProfileResourceStateMigrating` info [Changelog] - New const `ManagedServiceIdentityTypeSystemAssignedUserAssigned` info [Changelog] - New const `ProfileResourceStateCommittingMigration` info [Changelog] - New const `MetricsSeriesUnitCount` info [Changelog] - New const `ManagedServiceIdentityTypeSystemAssigned` info [Changelog] - New const `MetricsGranularityPT1H` info [Changelog] - New const `MetricsSeriesUnitBytes` info [Changelog] - New const `ManagedServiceIdentityTypeNone` info [Changelog] - New const `MetricsGranularityP1D` info [Changelog] - New const `CanMigrateDefaultSKUPremiumAzureFrontDoor` info [Changelog] - New const `MetricsSeriesUnitMilliSeconds` info [Changelog] - New const `ProfileResourceStateMigrated` info [Changelog] - New type alias `MetricsSeriesUnit` info [Changelog] - New type alias `CanMigrateDefaultSKU` info [Changelog] - New type alias `WafMetricsSeriesUnit` info [Changelog] - New type alias `ManagedServiceIdentityType` info [Changelog] - New type alias `MetricsGranularity` info [Changelog] - New type alias `WafMetricsGranularity` info [Changelog] - New function `PossibleWafMetricsGranularityValues() []WafMetricsGranularity` info [Changelog] - New function `*CustomDomainsClient.BeginEnableCustomHTTPS(context.Context, string, string, string, string, *CustomDomainsClientBeginEnableCustomHTTPSOptions) (*runtime.Poller[CustomDomainsClientEnableCustomHTTPSResponse], error)` info [Changelog] - New function `PossibleMetricsSeriesUnitValues() []MetricsSeriesUnit` info [Changelog] - New function `*AFDProfilesClient.ValidateSecret(context.Context, string, string, ValidateSecretInput, *AFDProfilesClientValidateSecretOptions) (AFDProfilesClientValidateSecretResponse, error)` info [Changelog] - New function `*ProfilesClient.BeginMigrationCommit(context.Context, string, string, *ProfilesClientBeginMigrationCommitOptions) (*runtime.Poller[ProfilesClientMigrationCommitResponse], error)` info [Changelog] - New function `*ProfilesClient.BeginMigrate(context.Context, string, MigrationParameters, *ProfilesClientBeginMigrateOptions) (*runtime.Poller[ProfilesClientMigrateResponse], error)` info [Changelog] - New function `*ProfilesClient.CanMigrate(context.Context, string, CanMigrateParameters, *ProfilesClientCanMigrateOptions) (ProfilesClientCanMigrateResponse, error)` info [Changelog] - New function `*CustomDomainsClient.BeginDisableCustomHTTPS(context.Context, string, string, string, string, *CustomDomainsClientBeginDisableCustomHTTPSOptions) (*runtime.Poller[CustomDomainsClientDisableCustomHTTPSResponse], error)` info [Changelog] - New function `*AFDProfilesClient.BeginUpgrade(context.Context, string, string, ProfileUpgradeParameters, *AFDProfilesClientBeginUpgradeOptions) (*runtime.Poller[AFDProfilesClientUpgradeResponse], error)` info [Changelog] - New function `PossibleManagedServiceIdentityTypeValues() []ManagedServiceIdentityType` info [Changelog] - New function `PossibleMetricsGranularityValues() []MetricsGranularity` info [Changelog] - New function `PossibleWafMetricsSeriesUnitValues() []WafMetricsSeriesUnit` info [Changelog] - New function `PossibleCanMigrateDefaultSKUValues() []CanMigrateDefaultSKU` info [Changelog] - New struct `AFDProfilesClientBeginUpgradeOptions` info [Changelog] - New struct `AFDProfilesClientUpgradeResponse` info [Changelog] - New struct `AFDProfilesClientValidateSecretOptions` info [Changelog] - New struct `AFDProfilesClientValidateSecretResponse` info [Changelog] - New struct `CanMigrateParameters` info [Changelog] - New struct `CanMigrateResult` info [Changelog] - New struct `CustomDomainsClientBeginDisableCustomHTTPSOptions` info [Changelog] - New struct `CustomDomainsClientBeginEnableCustomHTTPSOptions` info [Changelog] - New struct `DeepCreatedCustomDomain` info [Changelog] - New struct `DeepCreatedCustomDomainProperties` info [Changelog] - New struct `ManagedServiceIdentity` info [Changelog] - New struct `MigrateResult` info [Changelog] - New struct `MigrationErrorType` info [Changelog] - New struct `MigrationParameters` info [Changelog] - New struct `MigrationWebApplicationFirewallMapping` info [Changelog] - New struct `ProfileChangeSKUWafMapping` info [Changelog] - New struct `ProfileUpgradeParameters` info [Changelog] - New struct `ProfilesClientBeginMigrateOptions` info [Changelog] - New struct `ProfilesClientBeginMigrationCommitOptions` info [Changelog] - New struct `ProfilesClientCanMigrateOptions` info [Changelog] - New struct `ProfilesClientCanMigrateResponse` info [Changelog] - New struct `ProfilesClientMigrateResponse` info [Changelog] - New struct `ProfilesClientMigrationCommitResponse` info [Changelog] - New struct `UserAssignedIdentity` info [Changelog] - New field `ExtendedProperties` in struct `ProfileProperties` info [Changelog] - New field `ExtendedProperties` in struct `WebApplicationFirewallPolicyProperties` info [Changelog] - New field `ExtendedProperties` in struct `AFDDomainProperties` info [Changelog] - New field `Identity` in struct `ProfileUpdateParameters` info [Changelog] - New field `Identity` in struct `Profile` info [Changelog] info [Changelog] Total 38 breaking change(s), 94 additive change(s).
️❌ azure-sdk-for-net-track2 failed [Detail]
❌Failed [Logs]Release - Generate from 4903b1ed79e30f689d7c469cfa06734cfcd106d6. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json warn File azure-sdk-for-net_tmp/initOutput.json not found to read command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json cmderr [Invoke-GenerateAndBuildV2.ps1] [91mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:611 cmderr [Invoke-GenerateAndBuildV2.ps1] [96mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] [96m 611 | [0m [96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] [96m | [91m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] [91m[96m | [91mFailed to build sdk. exit code: False cmderr [Invoke-GenerateAndBuildV2.ps1] [0m
❌Azure.ResourceManager.Cdn [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Cdn.Models.MetricsResponseGranularity' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cdn/Azure.ResourceManager.Cdn/src/Azure.ResourceManager.Cdn.csproj], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Nullable<Azure.ResourceManager.Cdn.Models.MetricsResponseSeriesItemUnit> Azure.ResourceManager.Cdn.Models.MetricsResponseSeriesItem.Unit.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cdn/Azure.ResourceManager.Cdn/src/Azure.ResourceManager.Cdn.csproj], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Cdn.Models.MetricsResponseSeriesItemUnit' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cdn/Azure.ResourceManager.Cdn/src/Azure.ResourceManager.Cdn.csproj], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Nullable<Azure.ResourceManager.Cdn.Models.WafMetricsResponseGranularity> Azure.ResourceManager.Cdn.Models.WafMetricsResponse.Granularity.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cdn/Azure.ResourceManager.Cdn/src/Azure.ResourceManager.Cdn.csproj], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Cdn.Models.WafMetricsResponseGranularity' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cdn/Azure.ResourceManager.Cdn/src/Azure.ResourceManager.Cdn.csproj], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Nullable<Azure.ResourceManager.Cdn.Models.WafMetricsResponseSeriesItemUnit> Azure.ResourceManager.Cdn.Models.WafMetricsResponseSeriesItem.Unit.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cdn/Azure.ResourceManager.Cdn/src/Azure.ResourceManager.Cdn.csproj], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Cdn.Models.WafMetricsResponseSeriesItemUnit' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cdn/Azure.ResourceManager.Cdn/src/Azure.ResourceManager.Cdn.csproj], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Cdn/Debug/netstandard2.0/Azure.ResourceManager.Cdn.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cdn/Azure.ResourceManager.Cdn/src/Azure.ResourceManager.Cdn.csproj]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from 4903b1ed79e30f689d7c469cfa06734cfcd106d6. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
- Only show 120 items here, please refer to log for details.
️✔️@azure/arm-cdn [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - Added Interface EdgeNode info [Changelog] - Added Interface Endpoint info [Changelog] - Added Interface EndpointProperties info [Changelog] - Added Interface EndpointsCreateHeaders info [Changelog] - Added Interface EndpointsDeleteHeaders info [Changelog] - Added Interface EndpointsLoadContentHeaders info [Changelog] - Added Interface EndpointsPurgeContentHeaders info [Changelog] - Added Interface EndpointsStartHeaders info [Changelog] - Added Interface EndpointsStopHeaders info [Changelog] - Added Interface EndpointsUpdateHeaders info [Changelog] - Added Interface ManagedCertificate info [Changelog] - Added Interface ManagedCertificateParameters info [Changelog] - Added Interface ManagedRuleSetDefinition info [Changelog] - Added Interface ManagedServiceIdentity info [Changelog] - Added Interface MigrateResult info [Changelog] - Added Interface MigrationErrorType info [Changelog] - Added Interface MigrationParameters info [Changelog] - Added Interface MigrationWebApplicationFirewallMapping info [Changelog] - Added Interface Origin info [Changelog] - Added Interface OriginGroup info [Changelog] - Added Interface OriginGroupOverrideAction info [Changelog] - Added Interface OriginGroupProperties info [Changelog] - Added Interface OriginGroupsCreateHeaders info [Changelog] - Added Interface OriginGroupsDeleteHeaders info [Changelog] - Added Interface OriginGroupsUpdateHeaders info [Changelog] - Added Interface OriginProperties info [Changelog] - Added Interface OriginsCreateHeaders info [Changelog] - Added Interface OriginsDeleteHeaders info [Changelog] - Added Interface OriginsUpdateHeaders info [Changelog] - Added Interface PoliciesCreateOrUpdateHeaders info [Changelog] - Added Interface PoliciesUpdateHeaders info [Changelog] - Added Interface Profile info [Changelog] - Added Interface ProfileChangeSkuWafMapping info [Changelog] - Added Interface ProfilesCanMigrateOptionalParams info [Changelog] - Added Interface ProfilesCreateHeaders info [Changelog] - Added Interface ProfilesDeleteHeaders info [Changelog] - Added Interface ProfilesMigrateHeaders info [Changelog] - Added Interface ProfilesMigrateOptionalParams info [Changelog] - Added Interface ProfilesMigrationCommitHeaders info [Changelog] - Added Interface ProfilesMigrationCommitOptionalParams info [Changelog] - Added Interface ProfilesUpdateHeaders info [Changelog] - Added Interface ProfileUpgradeParameters info [Changelog] - Added Interface ProxyResource info [Changelog] - Added Interface RateLimitRule info [Changelog] - Added Interface Route info [Changelog] - Added Interface RouteProperties info [Changelog] - Added Interface RoutesCreateHeaders info [Changelog] - Added Interface RoutesDeleteHeaders info [Changelog] - Added Interface RoutesUpdateHeaders info [Changelog] - Added Interface Rule info [Changelog] - Added Interface RuleProperties info [Changelog] - Added Interface RulesCreateHeaders info [Changelog] - Added Interface RulesDeleteHeaders info [Changelog] - Added Interface RuleSet info [Changelog] - Added Interface RuleSetProperties info [Changelog] - Added Interface RuleSetsDeleteHeaders info [Changelog] - Added Interface RulesUpdateHeaders info [Changelog] - Added Interface Secret info [Changelog] - Added Interface SecretProperties info [Changelog] - Added Interface SecretsCreateHeaders info [Changelog] - Added Interface SecretsDeleteHeaders info [Changelog] - Added Interface SecurityPoliciesCreateHeaders info [Changelog] - Added Interface SecurityPoliciesDeleteHeaders info [Changelog] - Added Interface SecurityPoliciesPatchHeaders info [Changelog] - Added Interface SecurityPolicy info [Changelog] - Added Interface SecurityPolicyProperties info [Changelog] - Added Interface SecurityPolicyWebApplicationFirewallParameters info [Changelog] - Added Interface TrackedResource info [Changelog] - Added Interface UrlRedirectAction info [Changelog] - Added Interface UrlRewriteAction info [Changelog] - Added Interface UrlSigningAction info [Changelog] - Added Interface UrlSigningKeyParameters info [Changelog] - Added Interface UserAssignedIdentity info [Changelog] - Added Interface UserManagedHttpsParameters info [Changelog] - Added Type Alias AfdProfilesUpgradeResponse info [Changelog] - Added Type Alias AfdProfilesValidateSecretResponse info [Changelog] - Added Type Alias CanMigrateDefaultSku info [Changelog] - Added Type Alias EndpointProvisioningState info [Changelog] - Added Type Alias ManagedServiceIdentityType info [Changelog] - Added Type Alias MetricsGranularity info [Changelog] - Added Type Alias MetricsSeriesUnit info [Changelog] - Added Type Alias OriginGroupProvisioningState info [Changelog] - Added Type Alias OriginProvisioningState info [Changelog] - Added Type Alias ProfileProvisioningState info [Changelog] - Added Type Alias ProfilesCanMigrateResponse info [Changelog] - Added Type Alias ProfilesMigrateResponse info [Changelog] - Added Type Alias ResourceUsageUnit info [Changelog] - Added Type Alias WafMetricsGranularity info [Changelog] - Added Type Alias WafMetricsSeriesUnit info [Changelog] - Interface CustomDomainsDisableCustomHttpsOptionalParams has a new optional parameter resumeFrom info [Changelog] - Interface CustomDomainsDisableCustomHttpsOptionalParams has a new optional parameter updateIntervalInMs info [Changelog] - Interface CustomDomainsEnableCustomHttpsOptionalParams has a new optional parameter resumeFrom info [Changelog] - Interface CustomDomainsEnableCustomHttpsOptionalParams has a new optional parameter updateIntervalInMs info [Changelog] - Interface ProfileUpdateParameters has a new optional parameter identity info [Changelog] - Added Enum KnownCanMigrateDefaultSku info [Changelog] - Added Enum KnownEndpointProvisioningState info [Changelog] - Added Enum KnownManagedServiceIdentityType info [Changelog] - Added Enum KnownMetricsGranularity info [Changelog] - Added Enum KnownMetricsSeriesUnit info [Changelog] - Added Enum KnownOriginGroupProvisioningState info [Changelog] - Added Enum KnownOriginProvisioningState info [Changelog] - Added Enum KnownProfileProvisioningState info [Changelog] - Added Enum KnownResourceUsageUnit info [Changelog] - Added Enum KnownWafMetricsGranularity info [Changelog] - Added Enum KnownWafMetricsSeriesUnit info [Changelog] - Enum KnownProfileResourceState has a new value AbortingMigration info [Changelog] - Enum KnownProfileResourceState has a new value CommittingMigration info [Changelog] - Enum KnownProfileResourceState has a new value Migrated info [Changelog] - Enum KnownProfileResourceState has a new value Migrating info [Changelog] - Enum KnownProfileResourceState has a new value PendingMigrationCommit info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Removed operation group Validate info [Changelog] - Removed operation CustomDomains.disableCustomHttps info [Changelog] - Removed operation CustomDomains.enableCustomHttps info [Changelog] - Class CdnManagementClient no longer has parameter validate info [Changelog] - Removed Enum KnownMetricsResponseGranularity info [Changelog] - Removed Enum KnownMetricsResponseSeriesItemUnit info [Changelog] - Removed Enum KnownWafMetricsResponseGranularity
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs]Release - Generate from 4903b1ed79e30f689d7c469cfa06734cfcd106d6. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️cdn [View full logs] [Release Schema Changes]
️❌ azure-powershell failed [Detail]
❌Failed [Logs]Release - Generate from 4903b1ed79e30f689d7c469cfa06734cfcd106d6. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
❌Az.cdn [View full logs] [Release SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/cdn/armcdn | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
| Python | track2_azure-mgmt-cdn | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
| .Net | Azure.ResourceManager.Cdn | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
| JavaScript | @azure/arm-cdn | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
Hi @ChenglongLiu, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
| Task | How to fix | Priority |
|---|---|---|
| Avocado | Fix-Avocado | High |
| Semantic validation | Fix-SemanticValidation-Error | High |
| Model validation | Fix-ModelValidation-Error | High |
| LintDiff | Fix-LintDiff | high |
Hi @ChenglongLiu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.
The contribution checklist for this draft PR is not yet complete. When the draft is ready, please complete it, remove the ARMChangesRequested label, and send email to the current ARM API Review oncall when you are ready for ARM review.
In reply to: 1266212504
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested
"description": "Ok and the operation will complete synchronously.",
isn't it completed already?
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-11-01-preview/cdn.json:481 in fa36b8a. [](commit_id = fa36b8a8545c01cb44145b9855a89c9b7428b5c7, deletion_comment = False)
}
Why would 200 need location header? Normally only 202 does.
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-11-01-preview/cdn.json:486 in fa36b8a. [](commit_id = fa36b8a8545c01cb44145b9855a89c9b7428b5c7, deletion_comment = False)
"description": "Ok and the operation will complete synchronously.",
OK / Okay
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-11-01-preview/cdn.json:481 in fa36b8a. [](commit_id = fa36b8a8545c01cb44145b9855a89c9b7428b5c7, deletion_comment = False)
},
Please refactor definitions from common-types/v4/managedidentity.json if possible
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-11-01-preview/cdn.json:6887 in fa36b8a. [](commit_id = fa36b8a8545c01cb44145b9855a89c9b7428b5c7, deletion_comment = False)
"ProfileChangeSkuWafMapping": {
'Waf' looks a bit funny, and overall the name feels hard to understand the intent, what is this, Windows Azure Firewall? Can we come up with a better name?
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-11-01-preview/afdx.json:4027 in 50fc39d. [](commit_id = 50fc39dd34b21eed8e40b6de17d48facbcaa1a08, deletion_comment = False)
"description": "Waf mapping for the profile upgrade",
Whats a 'waf'?
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-11-01-preview/afdx.json:4053 in fa36b8a. [](commit_id = fa36b8a8545c01cb44145b9855a89c9b7428b5c7, deletion_comment = False)
},
I think best practice is to remove all these definitions and reference the parameter definitions in common-types/v3/types.json instead
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-11-01-preview/afdx.json:6070 in fa36b8a. [](commit_id = fa36b8a8545c01cb44145b9855a89c9b7428b5c7, deletion_comment = False)
"description": "Waf mapping for the profile upgrade",Whats a 'waf'?
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-11-01-preview/afdx.json:4053 in fa36b8a. [](commit_id = fa36b8a, deletion_comment = False)
"description": "Waf mapping for the profile upgrade",Whats a 'waf'?
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-11-01-preview/afdx.json:4053 in fa36b8a. [](commit_id = fa36b8a, deletion_comment = False)
Update the description.
Update the description.
"ProfileChangeSkuWafMapping": {'Waf' looks a bit funny, and overall the name feels hard to understand the intent, what is this, Windows Azure Firewall? Can we come up with a better name?
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-11-01-preview/afdx.json:4027 in 50fc39d. [](commit_id = 50fc39d, deletion_comment = False)
Update the description. 'Waf' indicate web application firewall. We also use 'Waf' in our portal and in the old version of swagger, we should keep it consistent.
"description": "Name of the Azure Front Door Standard or Azure Front Door Premium profile or CDN profile which is unique within the resource group.",
in this particular context, isn't it only going to be for CDN profiles?
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-11-01-preview/afdx.json:104 in 570a6ea. [](commit_id = 570a6ea38aaa01551692320ffd945997616f23d5, deletion_comment = False)
Hi @ChenglongLiu, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.
Hi, @ChenglongLiu, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline
@chenglongliu, regard to model validation errors, id is required field of a resource. Please add it to examples.
Approved for Go breaking changes, includes: non-LRO to LRO, add x-ms-enum, change model ref.
Approve for .NET breaking changes as they can be fixed by renaming configurations.
