ThomasGoulet73

Results 13 issues of ThomasGoulet73

Currently, `--with-access-specifier *=internal` does not seem to work and I think it would be useful when you want to generate internal bindings. Passing true as the fourth parameter in the...

## Description Change Substring for AsSpan for a method that already accepts a span. It looks like it was missed in dotnet/wpf#6268 when ParseParameterAndValue was changed to accept a span....

PR
Community Contribution

Follow up to dotnet/wpf#6693 ## Description Removes the remaining methods from SafeReflectionInvoker which was reverted in dotnet/wpf#6693 because of this comment: https://github.com/dotnet/wpf/pull/6693#issuecomment-1385285388 @dipeshmsft Let me know if/when you have more...

PR
Community Contribution

## Description Removes SecurityCriticalDataForSet which is unused since the removal of CAS attributes in dotnet/wpf#994. ## Customer Impact Should have tiny performance gain (Probably not measurable), it's mostly about removing...

PR
Community Contribution

## Description Remove FriendAccessAllowedAttribute usage since it is not enforced in .Net Core. FriendAccessAllowedAttribute is an undocumented and non-public attribute which is not supported anymore. To use `FriendAccessAllowedAttribute`, when supported,...

PR
Community Contribution

## Description This PR aims to fix MilCodeGen which seems to be very outdated and it doesn't seem like it ever worked in this repo (It probably worked in the...

PR
Community Contribution

Fixes dotnet/wpf#2543 Fixes dotnet/wpf#2926 Fixes dotnet/wpf#4457 Fixes dotnet/wpf#4538 Fixes dotnet/wpf#6198 ## Description There were many bug reports of different type that were all caused by the same bug. Xaml compilation...

PR
Queue for test pass
Community Contribution

Needed for dotnet/wpf#8215 ## Description Fixes unit tests native dependencies that were globbed too early which means that it skipped some dlls that were copied later in the build. I...

PR
Community Contribution

## Description ReadOnlyCollection does the same thing as PartialList but it's more optimized due to the fact that it does not support wrapping a range of a list and instead...

PR
Community Contribution

## Description I improved performance and allocations by using the new GetAlternateLookup introduced in .Net 9.0. This is a followup to dotnet/wpf#7794 where GetAlternateLookup wasn't available at the time. Here's...

PR
Community Contribution