Remove FriendAccessAllowedAttribute usage

[ThomasGoulet73]

Description

Remove FriendAccessAllowedAttribute usage since it is not enforced in .Net Core. FriendAccessAllowedAttribute is an undocumented and non-public attribute which is not supported anymore. To use FriendAccessAllowedAttribute, when supported, you need to set InternalsVisibleToAttribute.AllInternalsVisible to false, which is never set in this repo.

There are modifications to generated files in src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Generated but these files are generated from Elements.cs which is not runnable in this repo right now (dotnet/wpf#6135) but it should be fine because once we can run MilCodeGen, there shouldn't be any diffs.

Customer Impact

None.

Regression

No.

Testing

Local build + CI.

Risk

Low.

Microsoft Reviewers: Open in CodeFlow

[ThomasGoulet73]

I rebased to fix the conflicts.

[pchaurasia14]

Thanks @ThomasGoulet73! We'll consider this PR for our upcoming CTPs.

[ThomasGoulet73]

I rebased to fix the conflicts.

[lindexi]

I rebased to fix the conflicts.

Now, this branch has conflicts

[ThomasGoulet73]

I rebased to fix the conflicts.

Thanks for the ping @lindexi.

[JeremyKuhne]

https://github.com/dotnet/runtime/issues/10707 has some more details on this attribute.

[h3xds1nz]

Awesome! Those replacements from Thomas will clear out so much clutter.