Emelia Smith

Results 787 comments of Emelia Smith

In which case it should probably be reworded to be clearer: > Whilst JSON-LD does have capabilities to support relative URLs / `id`s in documents, plain old JSON parsers are...

It's not that JSON parsers are incapable of doing things with URLs, it's that to a JSON parser a URL carries no specific meaning, it's just a string. So `'my-actor'`...

iirc, videos taken on iPhone should be .mov files unless transcoded locally prior to upload, so I'm not sure why you've ended up with a .mp4 being processed

Okay, so, yeah, from what I can tell this snippet: ```ruby HTTP.get("https://example.com", ssl_context: OpenSSL::SSL::SSLContext.new.tap do |ctx| ctx.set_params( cert: OpenSSL::X509::Certificate.new(File.read("client.crt")), key: OpenSSL::PKey::RSA.new(File.read("client.key")) ) end) ``` becomes: ```ruby HTTP.get("https://example.com", ssl_context: OpenSSL::SSL::SSLContext.new.tap do...

The failure in [CI](https://github.com/opencollective/opencollective-frontend/actions/runs/16077242076/job/45375298612?pr=11344) appears to be unrelated to the changes in this pull request β€” I'm guessing a flakey test or something?

You might find that using something like hot-hook would give quicker development cycles: https://github.com/Julien-R44/hot-hook Essentially hot reloading the code that's changed rather than restarting the entire development environment.

definitely curious if you see any performance benefit from this!

Something I noticed whilst writing the tests is that we don't currently make use of the test IDs for various interactive elements, so changes to localisation may break the tests...

I think the test failure is unrelated, looks like something flakey happening. I've tried re-running several times and can't get it to pass correctly though. Edit: it was just the...

Have updated to add the obfuscation of emails in the SecondAuthenticationFactorRequiredError