Emelia Smith
Emelia Smith
> > I think ApplicationExtension, AccessTokenExtension, and AccessGrantExtension should all be custom models. > > I think this makes sense and would like to attempt it, but I'd like some...
Have rebased and updated this.
> This merged in doorkeeper - https://github.com/doorkeeper-gem/doorkeeper/pull/1735 Yeah, but I'm not sure the relevance? There's also a PR open for doing RFC 8414 for metadata discovery that will land once...
That is, the goal here is to try to remove the rather specific logic of "get a reference to the mastodon web UI OAuth app" which is done several different...
@mjankowski I'm thinking more towards things like: when an access token expires, we want to notify streaming that it's expired and also remove the web push subscription; I'm not sure...
Like, if a doorkeeper extension wants to revoke an access token, and it does `Doorkeeper::AccessToken` directly, then our `OAuth::AccessToken` hooks wouldn't fire correctly to notify streaming of the access token...
@ClearlyClaire are the changes in this roughly desired at all?
For the future additions, I'd also suggest hooks for when Fedify makes an outbound request for an actor or document or webfinger.
You could probably also inverse the control pattern here, by doing something like: ``` const federation = createFederation({ kv: new MemoryKvStore(), }); const debug = new DebugObserver({ path: '/__debugger__' });...
These would be best opened as issues for w3c/activitypub or w3c/activitystreams repos. But there's a lot of these inconsistencies that exist.