ThisIsFineTM
ThisIsFineTM
I had done some conversion in an experimental branch in my fork. These were the files that std::filesystem can apply to (not necessarily an exhaustive list): src/zimdump.cpp src/tools.cpp src/zimwriterfs/tools.cpp test/tools-test.cpp...
I'll flow the std::filesystem refactor work that I have in my side branch into a standalone PR. I'm rather busy at the moment so I probably won't get to it...
It looks like zim-tools, libkiwix, and kiwix-tools are using the same .clang-format file. https://github.com/kiwix/libkiwix/blob/main/.clang-format https://github.com/kiwix/kiwix-tools/blob/main/.clang-format libzim doesn't have one.
Using what is there already is probably fine as long as its applied consistently. If you want to experiment with the different clang-format settings, this has an interactive view you...
I should not be the one to submit the PR on this since it will touch so much of the code base. It would be more appropriate for one of...
@kelson42 I'll dig around github-ci/actions for the common guidance for setting that up. There are several entries in the marketplace which end up just running clang-format through a docker container....
@mgautierfr @veloman-yunkan @kelson42 I've gone through and applied the clang-format that exists in the repo to the codebase locally and noticed a few things in the diff that got changed...