ThisIsFineTM
ThisIsFineTM
Tagging #22258 just for my own awareness.
@cguerreroTT Still working on this. Main had some more python bindings go in so I've been getting those up to sync as well.
Yes. Had a bunch of new pybind changes come in and reflowing them to nanobind. Down to the last couple dozen files. Then I have to refactor something on the...
> Thank you for your work. > > Just one 'minor' thing: When applicable, can you set the headers of the new files to the following (I believe Merge Gate/CI...
Hi @minaliuTT. Resolved a batch of merge conflicts and ran into some segfaults. Fixed those. Now I am working on fixing a few remaining issues with device-host data moving.
> Turning it on by default, eh? Let's give it a go! > > https://github.com/tenstorrent/tt-metal/actions/runs/14919856602 Its off by default. The flag in cmake/project_options.cmake controls the codepath in cmake/linking.cmake. I made...
> Ah yes my apologies the first flag is `TT_ENABLE_LTO` - clearly illiterate. That's not to say that having one of the CI runs flipping the switch would be a...
> > LTO being enabled also adds -Wodr for warning of One Definition Rule violations. > > Are these related or orthogonal? Any reason we wouldn't just have -Wodr on...
I added a flag to make ODR issues warn only for the time being since #21850 hasn't been addressed yet. Also did some more cleanup and added lto-cache support.
@afuller-TT Did some cleanup and made the LTO hooks play nice with toolchains. Could use another look when you've got the time. @tt-rkim Added auto-enable for LTO for Release builds.