Jon Jackson
Jon Jackson
@stlaz I've made some changes, mind taking another look?
@stlaz I've separated the auth type flag and PR feedback into separate commits. PTAL.
@yanpzhan There should be no further changes unless @stlaz has any further comments.
/hold Looking into alternative fixes as this may introduce unneccessary complexity to our build.
I'm closing this as it introduces webpack issues that would need to be addressed separately. This change surfaces many import cycle issues that are currently ignored.
I just realized that we probably need to change the existing `createNamespaceModal,` `createProjectModal,` and `createNamespaceOrProjectModal` functions to use the `useModal` hook from the dynamic plugin SDK. The `createModalLauncher` function, part...
> I just realized that we probably need to change the existing `createNamespaceModal,` `createProjectModal,` and `createNamespaceOrProjectModal` functions to use the `useModal` hook from the dynamic plugin SDK. The `createModalLauncher` function,...
/lgtm cancel Since I helped implement this, I'll let someone else tag it.
/jira refresh
@stlaz @jhadvig PTAL