[WIP] Add extension point to enable customized create project modal for dynamic plugins

[sg00dwin]

…

[TheRealJon]

I just realized that we probably need to change the existing createNamespaceModal, createProjectModal, and createNamespaceOrProjectModal functions to use the useModal hook from the dynamic plugin SDK. The createModalLauncher function, part of our internal app, passes a different set of props than the launcher returned by useModal. We will want the new extension point to use props from the stable SDK API, not from our internal app.

[TheRealJon]

I just realized that we probably need to change the existing createNamespaceModal, createProjectModal, and createNamespaceOrProjectModal functions to use the useModal hook from the dynamic plugin SDK. The createModalLauncher function, part of our internal app, passes a different set of props than the launcher returned by useModal. We will want the new extension point to use props from the stable SDK API, not from our internal app.

This also means that these functions will need to be migrated to hooks

[sg00dwin]

/retest-required

[openshift-ci-robot]

@sg00dwin: This pull request references CONSOLE-3792 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sg00dwin]

/retest-required

[sg00dwin]

/retest-required

[sg00dwin]

/test e2e-gcp-console

[sg00dwin]

QE Approver /assign @yapei

Docs Approver: /assign @opayne1

PX Approver: /assign @RickJWagner

[TheRealJon]

/lgtm cancel

Since I helped implement this, I'll let someone else tag it.

[RickJWagner]

/label px-approved

[yapei]

tested following scenarios:

1. verify Create Project modal is using customized modal on several pages(project lists page; getting started page; project dropdown)
2. check Create Namespace modal, there is some problem here, user is unable to open the Default network policy dropdown

[yapei]

also one more question: customized namespace creation modal is not supported/implemented in this PR, right? Do we plan to support it in future?

[opayne1]

/label docs-approved

[sg00dwin]

also one more question: customized namespace creation modal is not supported/implemented in this PR, right? Do we plan to support it in future?

That is not implemented with this PR and there are no plans to support it.

[yapei]

Create Namespace modal still have some issues

• user need click twice to successfully switch to Deny all inbound traffic
• the dropdown item changed back to No restrictions after user clicks on Create button

https://github.com/openshift/console/assets/12692381/d6cd7f7b-96f2-4b34-84d3-e87993d9ef7f

[sg00dwin]

Hi @yapei I've pushed updates for those issues.

[yapei]

1. Create Namespace modal showing Default network policy with text allow

2. When creating a Namespace with Deny all inbound traffic , no NetworkPolicy is created but we expect a default-deny networkpolicy should be created

[sg00dwin]

I have pushed further updates for those issues. Please review.

[sg00dwin]

/retest

[openshift-ci[bot]]

@sg00dwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[yapei]

@sg00dwin thanks for all the updates, now everything works fine /label qe-approved

[openshift-ci-robot]

@sg00dwin: This pull request references CONSOLE-3792 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~dynamic-demo-plugin/OWNERS~~ [jhadvig,rhamilto]
• ~~frontend/OWNERS~~ [jhadvig,rhamilto]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.17.0-202406282112.p0.g2d4941b.assembly.stream.el9 for distgit openshift-enterprise-console. All builds following this will include this PR.