V

Results 17 comments of V

Current dev sourcepawn compiler have new parser and this problem has already been [reported](https://github.com/alliedmodders/sourcepawn/issues/401). You still can compile with 1.10 and use with 1.11. This must work correctly. If you...

> I'm guessing it hasn't been fixed since it isn't actually an issue as the TempUnBlock function resets the DataPack before doing anything else with it (LOL) Actually he right....

Wrong. Value must be `2`. My mistake. Positions start from `0`. Actually this code can be removed. https://github.com/sbpp/sourcebans-pp/blob/39ca1c51e56a81f0ec3abe1e3f4a1cd94d8caa65/game/addons/sourcemod/scripting/sbpp_comms.sp#L1393 https://github.com/sbpp/sourcebans-pp/blob/39ca1c51e56a81f0ec3abe1e3f4a1cd94d8caa65/game/addons/sourcemod/scripting/sbpp_comms.sp#L1425 https://github.com/sbpp/sourcebans-pp/blob/39ca1c51e56a81f0ec3abe1e3f4a1cd94d8caa65/game/addons/sourcemod/scripting/sbpp_comms.sp#L1499-L1523 This checks always `false`: https://github.com/sbpp/sourcebans-pp/blob/39ca1c51e56a81f0ec3abe1e3f4a1cd94d8caa65/game/addons/sourcemod/scripting/sbpp_comms.sp#L1512 https://github.com/sbpp/sourcebans-pp/blob/39ca1c51e56a81f0ec3abe1e3f4a1cd94d8caa65/game/addons/sourcemod/scripting/sbpp_comms.sp#L1517 Because `b_success == true`...

Сan someone test this version? https://github.com/TheByKotik/sourcebans-pp/blob/comms-fix-and-cleanup/game/addons/sourcemod/scripting/sbpp_comms.sp I'm did little changes and tried fix that. I can't test it in different situations also i haven't time for fix it by another...

sbpp_comms use natives from basecomms. basecomms provide Gag/Mute menu for Player Commands. I think is better totally rewrite sbpp_comms.

> I'm currently running the main branch for my production server, and I haven't been able to spot much of kinks compared to the current release. I can confirm this....

I think it would be better if rename folder `sourcebans` to `sbpp` and remove duplicates from configs names. * sourcebans/sb_admin_groups.cfg * sourcebans/sb_admins.cfg * sourcebans/sourcebans.cfg * sourcebans/sourcecomms.cfg * sourcebans/sourcesleuth_whitelist.cfg Like: *...

Good idea. I have long wanted to offer it.

> Oh wow, that's some horribly unreadable brace style there. Horribly unreadable style? I'm sorry. But, i'm easy to read that style. (; I'm see that code like: ![image](https://user-images.githubusercontent.com/40791562/60751725-491c8600-9fd4-11e9-89fb-d0ea82d9f24e.png) And...

I can just PrettyPrint that code. Better now? ``` // ************************************************************************* // This file is part of SourceBans++. // // Copyright (C) 2014-2016 SourceBans++ Dev Team // // SourceBans++ is...