Matt Corallo
Matt Corallo
Opened https://github.com/bitcoin/bips/pull/1672 and https://github.com/lightning/blips/pull/48
When you update the docs, please feel free to squash the commits down into one, but include more detail in the commit message - why was this change needed, what...
This basically LGTM, modulo the indentation note and the git commit message being missing. See https://cbea.ms/git-commit/ for a much, much, much longer discussion of how to write good commit messages.
I believe the reason has to do with an intermediary replaying the onion, not the sender. I don't recall the specific attack, but you could imagine something where an intermediate...
I'm definitely okay with having methods to override the router used, and like the changes to not decide in `ChannelManager` if a path should be compact or not, but I'm...
> It could create compact paths by default if ChannelManager were parameterized by CompactMessageRouter. And besides from having the user explicitly pass CompactMessageRouter to a one of the methods, how...
Looks like most of my previous comments went unaddressed? Just checking cause I interpreted your comment as you addressing them.
Okay, I probably spent a bit too long on it, but #3378 should let us drop the legacy fields in `outbound_payment.rs` at de-serialization time.
Lets get a review pass or two on #3378 and see if we want to move forward with it. If we do, we should rebase this on that and do...