TheAssassin comments

Results 1705 comments of


                                            TheAssassin

Deduplicate Qt plugins deployment

Should be fixed. Let's wait for the results. Thanks to @dantti and ~~all the reviewers~~ @bjorn for reviewing. I really do enjoy the outcome.

Add option to exclude specific plugins and handle missing dependencies as warnings

Please split into two commits.

Add option to exclude specific plugins and handle missing dependencies as warnings

Thanks @bjorn. After having a glance at the code again, I see so many problems in the code. Plus it now conflicts with the main branch. @jkennedyvz I suggest you...

Add option to exclude specific plugins and handle missing dependencies as warnings

Closing as obsolete.

Qt support agent claims that linuxdeploy patchelf is "corrupting" object files, problem seen on Qt66->Qt65 LTS downgrade

Some patchelf versions _can_ break binaries. The question is _how_. I don't have access to official binaries and am not really interested in working with these eitehr. Patches improving the...

Rename EXTRA_QT_PLUGINS to EXTRA_QT_MODULES

Feel free to squash the changes.

Rename EXTRA_QT_PLUGINS to EXTRA_QT_MODULES

Thanks! And sorry for the long delay. I've been really busy lately.

Update BUILDING.md

Not willing to review, as I am not willing to maintain this. https://github.com/AppImageCommunity/AppImageUpdate/issues/239#issuecomment-2499009192

Update BUILDING.md

They can read the Dockerfile, similar to how you did. Your information is not useful anyway as it focuses on an almost EOL Ubuntu and uses PPAs. It's not hard...

Update and improve BUILDING.md

There is no reason to maintain a building README in my opinion. We don't do that elsewhere either. And I certainly don't want to do it.