linuxdeploy
Deduplicate Qt plugins deployment
Sorry I added pre-commit locally to make sure clang-format was run and apparently your sources were not in sync with it
I have update with my .clang-format but still a bit different, I can manually fix it by hand :(, but I'd rather wait for your review and input about code style :)
This PR is unfortunately not acceptable because one cannot even tell what changes you implemented. You should never just run an autoformatter you like on an entire code base and the PR it.
Feel free to fix the PR and provide just the changes you want to propose. But, generally, I advise people to open issues first.
as I said I thought this project had .clang-format, it's a pain to work with projects that don't, and pre-commit just makes sure maintainers don't need to keed pointing to style issues which I have seen you pointing at on another PR.
I there was a proper style file I could just rebase and the PR would be fine.
@TheAssassin done, I didn't bother to remove the using namespace .. which is not in use anymore, I can remove if you like...
Basically, most deployers had the same code that I moved into BasicPluginsDeployer::deploy() and read what was changing in each deployer with the list from qtPluginsToBeDeployed, for the corner cases where there was more logic BasicPluginsDeployer::customDeploy() is called with no need to call the base class as the code should go to BasicPluginsDeployer::deploy().
Build failure is due to a change in the upstream runtime repo. Fixing this on master, rebasing afterwards.
Should be fixed. Let's wait for the results. Thanks to @dantti and ~~all the reviewers~~ @bjorn for reviewing. I really do enjoy the outcome.