TheAssassin

Results 1591 comments of TheAssassin
trafficstars

@alehaa I see your point. I'd say it makes only sense to set `Sanitizers_FOUND` to true when at least one of the modules has been found. However, I'd still like...

Found a way to check for it now: `if(NOT COMMAND add_sanitizers) [...]` seems to work. I'm working on implementing what I suggested in my last comment at the moment.

Updated the PR to use FindPackageHandleStandardArgs, which works fine in my tests. I'm not 100% sure how this `HANDLE_COMPONENTS` option works, though. I introduced a list variable `Sanitizers_COMPONENTS`, as CMake...

@alehaa That's the idea... finding out which sanitizers are available.

@alehaa that doesn't make sense, really. Why is it a problem to perform those tests? This CMake module _should_ provide information on whether sanitizers are available, and then provide information...

@alehaa I think it is sufficient to just remove the warnings, as described in https://github.com/arsenm/sanitizers-cmake/pull/18#issuecomment-403987407. I think hiding the tests themselves is wrong, it's better to give direct feedback to...

@alehaa if I'd remove those warnings, could we merge this, then?

Working on a quickfix in #18.

Looking into how to "detect" sanitizer support at the moment. There's `sanitizer_check_compiler_flags` in the helpers script, I'm looking into how it works and whether it can be modified to set...

Updated the PR to introduce FindPackageHandleStandardArgs, you're welcome to leave your comments there, everyone.