Tharo

Results 9 comments of Tharo
trafficstars

The VI reg defines are from libreultra & ultralib, not sure if they existed anywhere prior to libreultra

> (2) and (1) I think would be straight up removed in a clean-up pass, they aren't justified to exist, so I wouldn't think they deserve UNUSED I agree that...

> For unused parameters I have actually found that warnings are often more painful than useful even in a real codebase [...] Part of the rationale for why `__attribute__((unused))` exists...

I don't mind the inline nonmatching macro, although if we were to use a macro we could use a dedicated macro for stack padding? Maybe something like `#define STACK_PAD(type, n)...

The intention I had going into this is that these generic params macros introduced in this PR would be used to build specific macros for individual actors as they are...

> Very cool > > This doesn't change or add anything rendering-wise, right? Or does it allow rendering skeletons using skin/lod limbs? That's correct it doesn't add any new rendering...

This is simple to fix but this may result in regressions caused by loosening the detection by removing this check, and we don't have a way to check for regressions...

In the three MIPS cross compilers I have installed (`mips-linux-gnu-`, well-known, `mips64-ultra-elf-`, glank's toolchain, `mips64-elf-`, libdragon toolchain) I cannot find the definition `FLT_MAX`, only `MAXFLOAT` in `math.h`. Supposedly `FLT_MAX` is...

So far I've only been removing the ultratypes from libc files/functions, since libc shouldn't know anything about libultra. Otherwise I have no current plans to start removing them elsewhere