Z64Utils icon indicating copy to clipboard operation
Z64Utils copied to clipboard

[Object Analyzer] oot skeletons can have only 1 limb, but the detection assumes there must be at minimum 2

Open Dragorn421 opened this issue 4 years ago • 1 comments

The issue

"Analyze Dlists" on object_ik partially fails to detect things

According to the actor Demo_Ik there's a skeleton at 0xC90 but Z64utils doesn't list it

(there may be more stuff missing not sure)

and Z64Utils outputs many Overlapping data warnings

Why (for the undetected skeleton issue, at least)

quoting Tharo from the zeldaret discord:

oh huh that's interesting, in the skeleton detection I made an assumption that every skeleton will have at least 2+ limbs, but that skeleton appears to have only 1

The fix may be simple but I didn't look at doing it, just opening this issue to avoid completely forgetting about it

Dragorn421 avatar Aug 20 '21 17:08 Dragorn421

This is simple to fix but this may result in regressions caused by loosening the detection by removing this check, and we don't have a way to check for regressions right now beyond manually looking in a few object files which is not really sufficient.

Thar0 avatar Aug 23 '21 22:08 Thar0