TeoTwawki

well this is gonna be a fun rebase! and then I still have to actually fix it.

I think I'll split off the enum renaming parts, so that this deals solely with re-ordering.

I'm pretty much never going to have the time to return to this and fix its issues, and the rebase its needs will be straight up hellish. So no point...

Bless zach for proving so I didn't have to, but I should have been more specific woth what items I saw it with and included screen shots at the start...

Possibly. We'll find out before doing anything with it.

for enchantment effect last I knew attaching to the item was done via a subid and stats added in the item script, like with food. unless someone broke that (its...

https://github.com/LandSandBoat/server/blob/2377b2a3cee236fdad3357366762c9dd86a402ca/scripts/items/high_breath_mantle.lua#L22 you can have multiple unrelated enchantment effects from different items. this is why on retail you can stack the 2 different pelican rings if you have the old version...

> I actually wonder what happens if you're wearing 2 Albatross, Duck, or Pelican rings on retail. Does the effect wear only when you remove both rings, or specifically the...

> i thought i tried using enchantment and it didn't remove one removing the gear. Also `enchantment` status effect overwrites other enchantment status effects due to `overwrite == 0` on...

> afaik you can't set flags on an effect before applying it, and when you apply the overwrite check is done That's true, but the second the effect object exists...