server icon indicating copy to clipboard operation
server copied to clipboard

Re-align region IDs with what the client actually uses.

Open TeoTwawki opened this issue 2 years ago • 5 comments

(as seen in ROM/165/78.dat)

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [ ] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

https://gist.github.com/TeoTwawki/d46e51e761a95c6dffe11f0dc999f4d1

Steps to test these changes

Tested as far as build and boot, Xaver was going to do some further tests for me. Potential issues anywhere the Lua does a greater than or less than check on regions, and where regions equal a bit in a mask.

TeoTwawki avatar Jan 19 '23 00:01 TeoTwawki

✨ Thanks for the PR! ✨

This is a friendly automated reminder that the maintainers won't look at your PR until you've properly completed all of the checkboxes in the pre-filled template.

github-actions[bot] avatar Jan 19 '23 00:01 github-actions[bot]

Note: I am expecting issues related to Lua side region checks involved with bitmasks for teleports. Namely the expected bits might not be in the same expected order as the regions anymore. And I don't really know how to correct it should that prove to be the case.

TeoTwawki avatar Jan 19 '23 04:01 TeoTwawki

so far, from xavers testing:

  • I broke supplies
  • I broke conquest NPC selection for spawning
  • I broke conquest ranking display
  • I broke outpost warps
  • I broke unlocking them

I had this in draft mode I dunno what switched it, putting it back till issues resolved and dismissing current aprovals.

TeoTwawki avatar Jan 19 '23 13:01 TeoTwawki

well this is gonna be a fun rebase! and then I still have to actually fix it.

TeoTwawki avatar Feb 08 '24 05:02 TeoTwawki

I think I'll split off the enum renaming parts, so that this deals solely with re-ordering.

TeoTwawki avatar Feb 08 '24 05:02 TeoTwawki

I'm pretty much never going to have the time to return to this and fix its issues, and the rebase its needs will be straight up hellish. So no point in keeping this open.

TeoTwawki avatar Apr 19 '24 17:04 TeoTwawki