Andrey Anshin
Andrey Anshin
> `tests/providers/slack/notifications/test_slack_notifier.py` I think how to exclude case when the original module `airflow.providers.slack.notifications.slack_notifier` is deprecated
And just add here previous investigation about missing tests https://github.com/apache/airflow/pull/28459#discussion_r1054708003, non all of them actually missing: > * some of tests moved into tests.integrations > * Amazon links tested in...
And `codecov` statistic also might help to found untested parts: https://app.codecov.io/gh/apache/airflow/tree/main/airflow%2Fproviders
If you don't mind I've split this list by providers
@mateuslatrova Some test modules from your list do not exists or named differently ### Exists I've marked this as completed - [tests/providers/amazon/aws/triggers/test_athena.py](https://github.com/apache/airflow/tree/main/tests/providers/amazon/aws/triggers/test_athena.py) - [tests/providers/amazon/aws/triggers/test_batch.py](https://github.com/apache/airflow/tree/main/tests/providers/amazon/aws/triggers/test_batch.py) - [tests/providers/amazon/aws/triggers/test_emr.py](https://github.com/apache/airflow/tree/main/tests/providers/amazon/aws/triggers/test_emr.py) - [tests/providers/amazon/aws/triggers/test_glue_crawler.py](https://github.com/apache/airflow/tree/main/tests/providers/amazon/aws/triggers/test_glue_crawler.py) - [tests/providers/amazon/aws/triggers/test_lambda_function.py](https://github.com/apache/airflow/tree/main/tests/providers/amazon/aws/triggers/test_lambda_function.py)...
There is pretty simple rule there if providers module placed into the `airflow/providers/amazon/aws/operators/emr.py` then tests should be placed into the `tests/providers/amazon/aws/operators/test_emr.py`. Original check was broken for a while (1-2 years...
Maybe it is also good idea to implements DBFS over [Object Storage](https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/objectstorage.html)
And just wondering why not implement it over the [official SDK](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/files/dbfs.html)? Note about production usage from https://docs.databricks.com/en/dev-tools/sdk-python.html > [!NOTE] > This feature is in [Beta](https://docs.databricks.com/en/release-notes/release-types.html) and is okay to use...
> if it wouldn't be better to extend [this](https://filesystem-spec.readthedocs.io/en/stable/_modules/fsspec/implementations/dbfs.html) and then use it within ObjectStoragePath AIrflow ObjectStorage build in top of the `fsspec` and I guess extend some methods, like...
AFAIK `databricks-sql-connector` only supports SQLAlchemy 2, but Airflow and some components (FAB) only works with 1.4