Andrey Anshin

Results 182 comments of Andrey Anshin
trafficstars

Yeah, I agree that better implement as some abstract class or just raise an `NotImplementedError` on call specific method ```python class BaseCopyIntoTable(BaseOperator): def __init__(self, somearg, some_other_arg, **kwargs): super.__init__(**kwargs) ... def...

@blcksrx Personal thoughts just copy code from [S3ToSnowflakeOperator](https://github.com/apache/airflow/blob/main/airflow/providers/snowflake/transfers/s3_to_snowflake.py#L26-L28) create new operator based, and inherit S3ToSnowflakeOperator by new operator (with deprecation warnings) Everything except copyOptions and VALIDATION_MODE already implemented there. And...

> Crossed my mind too. I think it shoudl indeed be in the regular operators package. The only one case when it could be as `transfers` when query use credentials...

> This does not include the Assume Role methods and configuration framework offered by the [AWSBaseHook](https://github.com/apache/airflow/blob/main/airflow/providers/amazon/aws/hooks/base_aws.py#L609). I am proposing we extend the Secrets Backend integrations, so that they can be...

> It might also make sense to directly use the new released parameterized queries support for Athena: > https://aws.amazon.com/about-aws/whats-new/2021/07/amazon-athena-adds-parameterized-queries-to-improve-reusability-and-security/?nc1=h_ls I've checked. PREPARE statement pretty nice, however it also required escaping...

@jaidisido @cnfait - I found wrangler 3.0 in [Milestones](https://github.com/awslabs/aws-data-wrangler/milestone/25) So, probably it is a good time to change formatter for Athena queries (breaking changes)? I could work on this feature

I will try to create built-in formatter just for avoid additional imports

Just wondering is botocore>=1.28.0 still use `sslCommonName` by default? And for disable it still required to set env `BOTO_DISABLE_COMMONNAME=true`

@dlm6693 many thanks for detail explanation!

There is only one things remaining, that it exact the thing which describe into the issue This warning which might annoying end users because since Python 3.12+ such warnings become...